Ok i can push when im back at a computer (have changes locally). Do we want to introduce geronimo specific tests or wait until i can push to mp config?
On Jul 29, 2017 11:02 AM, "Mark Struberg" <[email protected]> wrote: > Oh I see. Now I get what you mean. > Yes, we should just register the same converters for their primitive > counterparts as well. > > LieGrue, > strub > > > Am 29.07.2017 um 13:12 schrieb John D. Ament <[email protected]>: > > > > Hey guys > > > > I raised a spec level issue on MP Config because primitives don't work > quite right in Geronimo Config and when I looked at the spec, it didn't say > they should. > > > > Basically, primitives aren't used in the TCK, and the follow behaviors > are noticed: > > > > int port = config.getValue("some key", Integer.class); // this works via > unboxing > > int port = config.getValue("some key", int.class); //fails due to > missing converter > > @Inject > > @ConfigProperty(name="some key",defaultValue = "8080") > > private int port; > > // also fails due to missing converter > > > > So should they? Is this a Geronimo specific issue? > > > > John > >
