+1 on releasing as is The notice and removal of the run_sigtest.sh file can happen later, if you wish.
Regards, Alan > On Aug 31, 2017, at 7:04 AM, John D. Ament <[email protected]> wrote: > > It looks like there's a few other errors in the NOTICE file. If you want I > can re-roll with the fixes. > > Sigtests were run as a part of > https://issues.apache.org/jira/browse/GERONIMO-6553 > <https://issues.apache.org/jira/browse/GERONIMO-6553> there were no sig > changes in this release. I'm actually not set up to run sigtests (and not > sure its relevance to this release). > > The tag can be found at > http://svn.apache.org/repos/asf/geronimo/specs/tags/geronimo-jcdi_2.0_spec-1.0.1/ > > <http://svn.apache.org/repos/asf/geronimo/specs/tags/geronimo-jcdi_2.0_spec-1.0.1/> > > John > > On Thu, Aug 31, 2017 at 9:50 AM Alan Cabrera <[email protected] > <mailto:[email protected]>> wrote: > Thanks. A few questions: > What is the tag for this release? > Do we want to include run_sigtest.sh and not the requisite test jars? > If the answer is yes, should we include a README that explains how to get the > test jars? > Should the NOTICE file have 2017 instead of 2015? > > Regards, > Alan > >> On Aug 31, 2017, at 3:19 AM, John D. Ament <[email protected] >> <mailto:[email protected]>> wrote: >> >> Thanks for the reminder Alan. Fixed, key is present now. >> >> John >> >> On Thu, Aug 31, 2017 at 2:26 AM Alan Cabrera <[email protected] >> <mailto:[email protected]>> wrote: >> John, is your key in https://svn.apache.org/repos/asf/geronimo/KEYS? >> <https://svn.apache.org/repos/asf/geronimo/KEYS?> >> >> >> Regards, >> Alan >> >>> On Aug 30, 2017, at 5:10 PM, John D. Ament <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Hi All >>> >>> I was running the steps needed to release JCDI 2.0 Spec v1.0.1. There's >>> only a couple small changes in this release: >>> >>> - Handle CDIProvider per the spec (cache the provider, lazily call the impl) >>> - Added a @since 2.0 on setObserverMethod >>> >>> Staging Repo: >>> https://repository.apache.org/content/repositories/orgapachegeronimo-1036/ >>> <https://repository.apache.org/content/repositories/orgapachegeronimo-1036/> >>> Source release: >>> https://repository.apache.org/content/repositories/orgapachegeronimo-1036/org/apache/geronimo/specs/geronimo-jcdi_2.0_spec/1.0.1/geronimo-jcdi_2.0_spec-1.0.1-source-release.zip >>> >>> <https://repository.apache.org/content/repositories/orgapachegeronimo-1036/org/apache/geronimo/specs/geronimo-jcdi_2.0_spec/1.0.1/geronimo-jcdi_2.0_spec-1.0.1-source-release.zip> >>> >>> (sha1, asc, md5 are next to this file) >>> >>> I'll leave this vote open at least 72 hours, hopefully get 3 binding +1's >>> by then. >>> >>> Here's my own +1 to release >>> >>> [ ] +1 ship it >>> [ ] +/- 0 don't care >>> [ ] -1 don't ship because... >> >
