Well the version is breaking people relying on snapshots for now
The lookup is not "wrong" but maybe not "final" ;)
The expensive part is quite not true since you will not evaluate it a lot
in general and even in such a case it is a light algorithm normally. The
current impl is wrongly using "replace("${" + varName + "}",
variableValue);" which is way more expensive than using substrings
(prefix+value+suffix) but overall it is acceptable for the config scope.
Not having the ability to have the ~same evaluation of values+defaults than
StrSubstitutor of [lang3] is quite a pain cause users and really used to
rely on that and it is mandatory for some path to use ${app.home}.
Le jeu. 7 juin 2018 à 10:56, Mark Struberg <[email protected]> a écrit :
> The lookup logic is also wrong.
>
> I know emily pushes for more replacements, but we discussed this through
> in ConfigJSR and so far most are opposed to such a wide framed replacement.
> The code is wrong as you cannot do just 1 fallback but you would have to
> do multiple fallback lookups. Which might become rather expensive.
>
> This is still under discussion.
>
> LieGrue,
> strub
>
>
> > Am 07.06.2018 um 06:44 schrieb Romain Manni-Bucau <[email protected]
> >:
> >
> > Oki, thanks JL.
> >
> > Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[email protected]> a
> écrit :
> > If I forget, just ping me in the morning
> >
> > Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[email protected]> a
> écrit :
> > I can do tomorrow if you want
> >
> >
> > Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[email protected]>
> a écrit :
> > Oki, do you revert it (or i can do it tomorrow)?
> >
> > Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[email protected]> a
> écrit :
> > I think so. Mistake maybe
> >
> > Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[email protected]>
> a écrit :
> > Ok,
> >
> > seems it comes from the PR apply of
> https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243
> >
> > can it be reverted please (just the version)?
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book
> >
> >
> > Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[email protected]>
> a écrit :
> > Hi guys,
> >
> > why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?
> >
> > Romain Manni-Bucau
> > @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book
>
>
