On Thu, Jan 17, 2019 at 12:11 PM Romain Manni-Bucau <rmannibu...@gmail.com>
wrote:

> I would prefer to not leak specs between them since they are used without
> the others today.
>
> What is missing for it to work, returned types are explicit no?
>
It misses ResponseCodes, without that swagger ui doesn't work.

> Last releases got some work to have it working OOTB so this can likely be
> enhanced again if required.
>
What is OOTB?

> Also something unclear is if they should appear or not in the openapi
> report (we made the choice to do but it is not required AFAIK)
>
> In my opinion we should keep it, but have at list a basic configure.
@ResponseCode 200 should be there as it is the expected response code.

> Another option for tomee would be to enrich the OpenAPI with what it need,
> there is the API for that.
>
> Can you elaborate?

> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le jeu. 17 janv. 2019 à 14:49, Ivan Junckes Filho <ivanjunc...@gmail.com>
> a écrit :
>
>> Hey guys, I was trying to make the openapi document generated by
>> geronimo-openapi to work with swagger-ui. The issue is I can't execute
>> requests from swagger-ui in the endpoints generated (metrics, health,
>> openapi) by TomEE as they don't have a @ApiResponse annotation and
>> swagger-ui doesn't display the message without that.
>>
>> What do you guys think of having this annotation by default in the
>> endpoints? At least for 200?
>>
>> Or anyone has a better solution for this?
>>
>

Reply via email to