rmannibucau commented on pull request #5:
URL: https://github.com/apache/geronimo-txmanager/pull/5#issuecomment-778795990
@efge yes and no. The main issue is clock as an API requires 6 methods to be
implemented whereas we just need one to evaluate current time (in ms) so I'd
use a CurrentTimeMsProvider {now()} interface + SystemCurrentImpl {} +
ClockImpl {ClockImpl(Clock)}. Default would be SystemCurrentImpl and you can
configure it to use clock one if needed - but note that once you have this
interface you just implement a lambda instead of implementing a Clock which is
way simpler for testing with is your use case, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
