[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

[GitBox]

rmannibucau commented on code in PR #34:
URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045282542


##########
xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java:
##########
@@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {
 
     @Test
     public void testIterator() throws Exception {
-        List<String> actual = new ArrayList<>();
-        for (Archive.Entry entry : this.archive) {
+        List<String> actual = new ArrayList<String>();
+        for (Archive.Entry entry : archive) {
             actual.add(entry.getName());
         }
 
         Assert.assertFalse(0 == actual.size());
 
-        for (Class clazz : JarArchiveTest.classes) {
+        for (Class clazz : classes) {
             Assert.assertTrue(clazz.getName(), 
actual.contains(clazz.getName()));
         }
 
         Assert.assertEquals(JarArchiveTest.classes.length, actual.size());
     }
 
-

Review Comment:
   Not sure what you mean but we should probably keep current exception 
behavior, we can change messages if you think it is relevant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org