rmannibucau commented on code in PR #12:
URL: https://github.com/apache/geronimo-arthur/pull/12#discussion_r1114214084
##########
arthur-maven-plugin/src/main/java/org/apache/geronimo/arthur/maven/mojo/ArthurMojo.java:
##########
@@ -194,8 +195,9 @@ private String buildDownloadUrl(final String graalPlatform)
{
final String graalJavaVersion = versionIncludesJavaVersion ?
versionSegments[versionSegments.length - 1].substring(1) :
System.getProperty("java.version", "1.8").startsWith("8") ?
"8" : "11";
- final String githubPlatform = graalPlatform.contains("win") ?
- "windows-amd64" : (graalPlatform.contains("linux") ?
"linux-amd64" : "darwin-amd64");
+ final String githubPlatform =
graalPlatform.toLowerCase(ROOT).contains("win") ?
+ "windows-amd64" :
(graalPlatform.toLowerCase(ROOT).contains("linux") ?
Review Comment:
is it an option to reverse the test to fallback on linux (as before) and not
on macos?
rest looks perfect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
