rmannibucau commented on code in PR #47:
URL: https://github.com/apache/geronimo-xbean/pull/47#discussion_r2653875502
##########
xbean-reflect/src/main/java/org/apache/xbean/recipe/ReflectionUtil.java:
##########
@@ -1039,7 +1065,7 @@ private static String toParameterList(List<? extends
Class<?>> parameterTypes) {
for (int i = 0; i < parameterTypes.size(); i++) {
Class type = parameterTypes.get(i);
if (i > 0) buffer.append(", ");
- buffer.append(type.getName());
+ buffer.append(type != null ? type.getName() : "...");
Review Comment:
Hmm, I guessed so but why does it happen now and was not before? Is it about
the ServiceProviders, did something changed ?
to be clear I'm not against the change just want to ensure it is not a
misusage cause we are loosing information there in user facing error messages,
will be less usable ("oh it failed in constructor Foo(..., ..., ....)")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
