[
https://issues.apache.org/jira/browse/GIRAPH-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295181#comment-13295181
]
Eugene Koontz commented on GIRAPH-205:
--------------------------------------
This seems right to me. In addition to this, we should also change the "else"
section (which handles the dev environment setup) from:
{code}
for f in $GIRAPH_HOME/target/giraph*.jar ; do
if [ -e "$f" ]; then JAR=$f
break
fi
done
{code}
to something like:
{code}
for f in `find $GIRAPH_HOME/target -name giraph*.jar` ; do
if [ -e "$f" ]; then JAR=$f
break
fi
done
{code}
to find jars created when using hadoop version profiles (e.g.
hadoop_0.20.203.0) that require munging (such jars will be in target/munged).
> giraph launcher script does not look for giraph jar file under GIRAPH_HOME
> --------------------------------------------------------------------------
>
> Key: GIRAPH-205
> URL: https://issues.apache.org/jira/browse/GIRAPH-205
> Project: Giraph
> Issue Type: Bug
> Components: conf and scripts
> Affects Versions: 0.2.0
> Reporter: Roman Shaposhnik
> Fix For: 0.2.0
>
>
> I see the following bit of code in bin/giraph:
> {noformat}
> for f in $GIRAPH_HOME/lib/giraph*.jar ; do
> if [ -e "$f" ]; then
> JAR=$f
> break
> fi
> done
> {noformat}
> I find it puzzling that it doesn't look for $GIRAPH_HOME/giraph*.jar
> In fact, I find it puzzling that it looks under lib at all, since my
> assumption is that lib is supposed to hold the dependencies only.
> Either way, I suggest that we modify it to be:
> {noformat}
> for f in $GIRAPH_HOME/lib/giraph*.jar $GIRAPH_HOME/giraph*.jar ; do
> if [ -e "$f" ]; then
> JAR=$f
> break
> fi
> done
> {noformat}
> Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
