[
https://issues.apache.org/jira/browse/GIRAPH-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400762#comment-13400762
]
Jakob Homan commented on GIRAPH-217:
------------------------------------
Overall, looks good. Review:
* Rather than recommending a specific in/output format, how about describing
the expected structure of the graph and then recommending those formats?
* Please describe what the algorith does in the javadoc, its input and final
output state
* It'd be good to have a lots of javadoc explaining the algorithm so that new
users can follow along easily
* Unit tests
> Add SimpleTriangleClosingVertex to Giraph examples
> --------------------------------------------------
>
> Key: GIRAPH-217
> URL: https://issues.apache.org/jira/browse/GIRAPH-217
> Project: Giraph
> Issue Type: Bug
> Components: examples
> Affects Versions: 0.2.0
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-217-1.patch, GIRAPH-217-2.patch
>
>
> Very simple triangle closing vertex using ID values, mostly for scale testing
> purposes, same as PR and shortest paths vertex examples. Might get fancier at
> a later date...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
