[
https://issues.apache.org/jira/browse/GIRAPH-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407371#comment-13407371
]
Hyunsik Choi commented on GIRAPH-233:
-------------------------------------
+1
These bug fixes look reasonable.
I verified the patch, and the unittests are all passed.
If there is no any objection, I'll commit tomorrow.
Thanks!
> Small errors found by FindBugs
> ------------------------------
>
> Key: GIRAPH-233
> URL: https://issues.apache.org/jira/browse/GIRAPH-233
> Project: Giraph
> Issue Type: Bug
> Reporter: Jan van der Lugt
> Assignee: Jan van der Lugt
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: GIRAPH-233.patch, GIRAPH-233.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I ran FindBugs on the Giraph codebase and found some small peculiarities that
> can be fixed easily. Some of them are just making some fields or inner
> classes static, but there was also a case of an inputstream not being closed.
> These issues seem to minor to deserve a JIRA each, so here they are, combined
> into one JIRA. It passes mvn verify.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
