[ 
https://issues.apache.org/jira/browse/GIRAPH-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410668#comment-13410668
 ] 

Jan van der Lugt commented on GIRAPH-236:
-----------------------------------------

Any more thoughts on this? I think it would be a good idea to add the 
exceptions to findbugs-exclude.xml with an explanation per exception, this way 
we can track where fishy tricks are being used and why. An example would be 
saving a value to a static variable, this is generally not advised, but may be 
more efficient in some cases. Either way it would be good to document why such 
a trick is being used.
                
> Add FindBugs to maven build
> ---------------------------
>
>                 Key: GIRAPH-236
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-236
>             Project: Giraph
>          Issue Type: Task
>          Components: build
>            Reporter: Hyunsik Choi
>            Assignee: Jan van der Lugt
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-236.patch, GIRAPH-236.patch
>
>
> Integrating findbugs with the maven build will reduce coding errors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to