[
https://issues.apache.org/jira/browse/GIRAPH-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Reisman updated GIRAPH-218:
-------------------------------
Attachment: GIRAPH-218-4.patch
I just redid this from scratch, compiles great with changes in the code up to
July 11. This is good, because this moves some IO formats into lib/ to
consolidate them so future patches could make this stale again soon.
My approach, given what the comments were here, was:
IO format implementations go into lib/ directory.
IO format interfaces stay in graph/
Bsp{Input,Output}Format stays in bsp/
giraph-contrib stuff stays where it was as it relates to outside projects (see
Jakob's post here)
JsonBase64 stuff stays in lib/ but if we get library-specific JSON stuff in the
future then thats a debate for the future. As we develop a richer set of JSON
formats, perhaps they could have their own home like the giraph-contrib stuff?
Again, see Jakob and Brian's posts here.
If anyone has fundamental objections to this, please review and lets kill this
now because it will go stale again quickly. I think its a decent compromise
that makes like tools easier to find for new users pretty well with minimal
changes to existing code (mostly just re-setting some imports in the tests)
> Consolidate all I/O Format classes under one roof in lib/ directory
> -------------------------------------------------------------------
>
> Key: GIRAPH-218
> URL: https://issues.apache.org/jira/browse/GIRAPH-218
> Project: Giraph
> Issue Type: Bug
> Components: lib
> Reporter: Eli Reisman
> Assignee: Eli Reisman
> Priority: Trivial
> Labels: patch
> Attachments: GIRAPH-218-3.patch, GIRAPH-218-4.patch
>
>
> Just some housekeeping to consolidate all Input and Output formats under the
> src/main/java/org/apache/giraph/lib directory, rather than spread amongst
> several directories. This makes it easier for new users to find and review
> them, and to decide if they can make use of one of them before implementing
> their own.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
