----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5986/#review9191 -----------------------------------------------------------
http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java <https://reviews.apache.org/r/5986/#comment19672> Maybe ServerData should own the combiner? It's a little strange that the request has the combiner. This only works because the combiner is created upon reflection when the request is received. http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java <https://reviews.apache.org/r/5986/#comment19670> This should also be done in the non-reflection constructor. - Avery Ching On July 16, 2012, 1:56 p.m., Alessandro Presta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5986/ > ----------------------------------------------------------- > > (Updated July 16, 2012, 1:56 p.m.) > > > Review request for giraph and Avery Ching. > > > Description > ------- > > Uses the combiner for incoming messages on the server. > > > This addresses bug GIRAPH-224. > https://issues.apache.org/jira/browse/GIRAPH-224 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java > 1357172 > > Diff: https://reviews.apache.org/r/5986/diff/ > > > Testing > ------- > > mvn verify > > > Thanks, > > Alessandro Presta > >
