----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6001/ -----------------------------------------------------------
Review request for giraph. Description ------- makes -P profiles build properly (the maven repo fills up with new profile-related jars when I run it, so I know its working) and the resulting artifacts have this appended in the name "for-hadoop-XXX" where XXX is the version # of Hadoop compatible with that profile (according to the POM.XML where profiles are defined.) Diffs ----- Diff: https://reviews.apache.org/r/6001/diff/ Testing ------- When most recent patch was submitted (july 11, 2012). Tests with various -P maven options, with this fix -Dhadoop=... does not seem to affect which profile is chosen any more (I moved this job to <forHadoop> property, and moved the default setting for this to the default profile markup and out of the global properties section, which seemed to allow a cleaner solution) Thanks, Eli Reisman
