[
https://issues.apache.org/jira/browse/GIRAPH-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426501#comment-13426501
]
Alessandro Presta commented on GIRAPH-272:
------------------------------------------
Sorry for the delay, I just came back from vacation.
I'm all for giving the user freedom to customize, while preventing him from
shooting himself in the foot.
Unfortunately in this case, we either go with the former or the latter. I
propose to make those methods public, since I think preventing the user from
optimizing edge storage is the worst possible scenario (I didn't realize this
myself, thanks for pointing it out).
Think of IntIntNullIntVertex: one might want to do that kind of optimization
for other id/value types.
If we eventually take message storage out of Vertex (which is what out-of-core
messaging will require anyway) then we can get rid of get/putMessages and
releaseResources.
I'm attaching a fix for this, let me know your thoughts.
> cannot extend Vertex in user code
> ---------------------------------
>
> Key: GIRAPH-272
> URL: https://issues.apache.org/jira/browse/GIRAPH-272
> Project: Giraph
> Issue Type: Bug
> Components: graph
> Affects Versions: 0.2.0
> Reporter: Joseph Adler
> Priority: Critical
> Attachments: GIRAPH-272.patch
>
>
> As currently written, it's not possible to create a class that extends Vertex
> in user code. I think this is because the abstract methods putMessages and
> releaseResources are abstract and neither public nor protected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
