[
https://issues.apache.org/jira/browse/GIRAPH-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428372#comment-13428372
]
Jakob Homan commented on GIRAPH-258:
------------------------------------
Review:
GiraphRunner.java
+ validator.validateClassTypes(); // to please findbugs
How so? (this comment shows up a bunch. It's probably not helpful in the long
term)
GiraphTypeValidator.java
* Constructor comment is a bit confusing.
* Please refactor the if(blah == null) { etc etc} into a utility class so as
not to have the same basic code path repeated
* Constants rather than naked numbers.
* It may make sense to subclass IllegalStateException to better encapsulate
what we're trying to here.
TestVertexTypes.java
* Is there any reason not call fail rather throwing RTE when a test fails?
Alternatively, we can just use the expected annotation, particularly if we
subclass ISE
Also, what testing has been done?
> Check type compatibility before submitting job
> ----------------------------------------------
>
> Key: GIRAPH-258
> URL: https://issues.apache.org/jira/browse/GIRAPH-258
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Jakob Homan
> Assignee: Eli Reisman
> Fix For: 0.2.0
>
> Attachments: GIRAPH-258-1.patch
>
>
> Currently if one submits a job with a vertex and inputformat types that are
> not compatible the job only fails during runtime. Since we know the types at
> submission time, we can check this before submitting and fail then.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
