[ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430368#comment-13430368 ]
Maja Kabiljo commented on GIRAPH-259: ------------------------------------- Removed json. Passes mvn verify and test in pseudo distributed mode. I updated Review Board also: https://reviews.apache.org/r/6134/diff/3/ This can later be improved by having aggregator types and not writing whole aggregator class name every time. Another thing to consider is having numbers instead of strings for aggregator ids (this would make more sense and decrease the amount of data sent, if we have a lot of aggregators with simple aggregated value objects). But for now, this makes aggregators work correctly. > TestBspBasic.testBspPageRank is broken > -------------------------------------- > > Key: GIRAPH-259 > URL: https://issues.apache.org/jira/browse/GIRAPH-259 > Project: Giraph > Issue Type: Bug > Reporter: Maja Kabiljo > Assignee: Maja Kabiljo > Attachments: GIRAPH-259-1.patch, GIRAPH-259-2.patch, > GIRAPH-259-3.patch, GIRAPH-259-4.patch, GIRAPH-259-5.patch > > > Test crashes on line 152 in class SimplePageRankVertex in distributed mode. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira