[ 
https://issues.apache.org/jira/browse/GIRAPH-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445730#comment-13445730
 ] 

Eli Reisman commented on GIRAPH-313:
------------------------------------

Sorrry I didn't get back to you on rb sooner, didn't see the email until now. 
Stuff like this is what I meant:

WritableRequest writableRequest =
         ReflectionUtils.newInstance(writableRequestClass, conf);

We do a lot of reflection in this code, and we maintain the IVEM type info 
often by just having it declared everywhere, so I tend to have a knee jerk 
reaction when I see wildcard param or IVEM stuff vanish in a patch. If its 
working then sounds great to me.

                
> Open Netty client and server on master
> --------------------------------------
>
>                 Key: GIRAPH-313
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-313
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Eli Reisman
>         Attachments: GIRAPH-313.patch
>
>
> For GIRAPH-273 first thing we need is to open Netty communication on master, 
> make connections to workers and make connections from workers to master.
> Since it's already significant amount of code I'm opening a separate issue 
> for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to