[ https://issues.apache.org/jira/browse/GIRAPH-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454725#comment-13454725 ]
Maja Kabiljo commented on GIRAPH-314: ------------------------------------- Sorry that I keep asking about this, but here is the thing I'm trying to get to with your problem size discussion: is above described combiner together with limiting number of open requests (but still everything in-core) a good alternative to this solution, and if not why not? Amortizing says convert messages to these maps every once in a while - that's what combiner could do. And amortizing says wait for part of messages to be processed before sending/receiving new ones - that's what limiting number of open requests does. > Implement better message grouping to improve performance in > SimpleTriangleClosingVertex > --------------------------------------------------------------------------------------- > > Key: GIRAPH-314 > URL: https://issues.apache.org/jira/browse/GIRAPH-314 > Project: Giraph > Issue Type: Improvement > Components: examples > Affects Versions: 0.2.0 > Reporter: Eli Reisman > Assignee: Eli Reisman > Priority: Trivial > Fix For: 0.2.0 > > Attachments: GIRAPH-314-1.patch, GIRAPH-314-2.patch, > GIRAPH-314-3.patch, GIRAPH-314-4.patch > > > After running SimpleTriangleClosingVertex at scale I'm thinking the > sendMessageToAllEdges() is pretty in the code, but its not a good idea in > practice since each vertex V sends degree(V)^2 messages right in the first > superset in this algorithm. Could do something with a combiner etc. but just > grouping messages by hand at the application level by using > IntArrayListWritable again does the trick fine. > Probably should have just done it this way before, but > sendMessageToAllEdges() looked so nice. Sigh. Changed unit tests to reflect > this new approach, passes mvn verify and cluster, etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira