[
https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463738#comment-13463738
]
Alessandro Presta commented on GIRAPH-340:
------------------------------------------
I'm not that familiar with Netty, but if benchmarks show this is a winner I'm
all for it.
Predicting the buffer size sounds good. The reason you had to wrap it is only
to add some logging, right?
This javadoc is incomplete: "Uses composition to learn more about what
AdaptiveReceive".
> Added client/server ExecutionHandlers to Netty to avoid and added
> WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of
> the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the
> business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the
> size of the incoming messages and provide better performance tuning on the
> server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
