[
https://issues.apache.org/jira/browse/GIRAPH-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465119#comment-13465119
]
Brian Femiano commented on GIRAPH-350:
--------------------------------------
Attach patch was applied over a fresh checkout from SVN. Passes all checkstyle
requirements as documented in GIRAPH-336.
This patch makes the following changes to giraph-formats-contrib:
-adds static setConf() methods to HBaseVertexInputFormat and
HBaseVertexOutputFormat.
-removes Configurable interface from HBase and Accumulo formats.
-all review comments made in https://reviews.apache.org/r/7310/
> HBaseVertex i/o formats are not being injected with Configuration via
> Configurable interface
> --------------------------------------------------------------------------------------------
>
> Key: GIRAPH-350
> URL: https://issues.apache.org/jira/browse/GIRAPH-350
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Brian Femiano
> Assignee: Brian Femiano
> Fix For: 0.2.0
>
> Attachments: GIRAPH-350.patch
>
>
> I reinstalled the latest giraph version from trunk.
> When running the unit tests, I noticed the setConf(Configuration conf) is not
> being called, and therefore the delegate 'tableInputFormat' is never being
> configured properly. The Accumulo i/o formats use static setters to avoid
> this requirement. That has the unfortunate side effect of having to remember
> to call those before setting up GiraphJob.
> I can add this same static-method solution to HBaseVertex i/o, depending on
> whether Configurable is an easy fix. I would imagine other input/output
> formats would have this same issue.
> If static setters are acceptable (same as Accumulo) I can add that to the
> Giraph-336 patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
