[ 
https://issues.apache.org/jira/browse/GIRAPH-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468282#comment-13468282
 ] 

Hudson commented on GIRAPH-293:
-------------------------------

Integrated in Giraph-trunk-Commit #216 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/216/])
    GIRAPH-293: Should aggregators be checkpointed? (Revision 1393264)

     Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393264
Files : 
* /giraph/trunk/CHANGELOG
* 
/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java
* 
/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorHandler.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/BspService.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* 
/giraph/trunk/src/main/java/org/apache/giraph/graph/MasterAggregatorHandler.java
* /giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
* 
/giraph/trunk/src/main/java/org/apache/giraph/graph/WorkerAggregatorHandler.java
* /giraph/trunk/src/test/java/org/apache/giraph/TestAggregatorsHandling.java
* 
/giraph/trunk/src/test/java/org/apache/giraph/graph/TestAggregatorsHandling.java

                
> Should aggregators be checkpointed?
> -----------------------------------
>
>                 Key: GIRAPH-293
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-293
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-293.patch, GIRAPH-293.patch, GIRAPH-293.patch, 
> GIRAPH-293.patch, GIRAPH-293.patch
>
>
> As I understand, we don't include aggregators in checkpoints because they are 
> kept in the Zookeeper.
> One of our bootcampers is working on fixing TestManualCheckpoint, which 
> currently involves starting a new job from a checkpoint from a previous job*.
> If this is a functionality we want going forward, then persistent aggregators 
> should be checkpointed.
> [*] That test relies on the fact that either aggregators are checkpointed or 
> they are always reset at each superstep. None of these is happening, but the 
> error cancels out with the fact that we are not actually resuming from a 
> checkpoint, but re-running the job from scratch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to