[ 
https://issues.apache.org/jira/browse/GIRAPH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470511#comment-13470511
 ] 

Avery Ching commented on GIRAPH-357:
------------------------------------

Agreed with everyone [~apresta] wrote.  Serializing straight away on the client 
is a good strategy to check out as you mentioned.
                
> Don't try to combine if there is only one message
> -------------------------------------------------
>
>                 Key: GIRAPH-357
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-357
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-357.patch
>
>
> In SendMessageCache, we call combiner even if we have just one message. 
> Combining is kind of expensive since we recreate the message object and the 
> list. With default settings and bigger graph, for PageRankBenchmark there is 
> 10-15% superstep speedup if we don't call it when we have a single message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to