[ 
https://issues.apache.org/jira/browse/GIRAPH-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitay Joffe resolved GIRAPH-55.
-------------------------------

    Resolution: Invalid
    
> BasicRPCCommunications shouldn't implement both CommunicationsInterface and 
> ServiceInterface
> --------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-55
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-55
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>
> Currently, BasicRPCCommunications, the base class for RPC in a worker, 
> implements both the server interface and the proxy-to-other-workers 
> interface.  It would be much easier to test and refactor if these 
> responsibilities were divided into two different classes and the 
> RPCCommunications merged interface went away.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to