> On Nov. 9, 2012, 2:04 a.m., Maja Kabiljo wrote: > > giraph/src/main/java/org/apache/giraph/master/MasterObserver.java, line 24 > > <https://reviews.apache.org/r/7981/diff/1/?file=187482#file187482line24> > > > > How about adding preApplication, pre/postSuperstep, like in > > WorkerContext? A > > lso, I think MasterObserver should at least be Configurable, or have a > > GraphState in there, so we could access application state from implementing > > classes.
K I've made it ImmutableClassesGiraphConfigurable. If people need something bigger like GraphState we can change it later. - Nitay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7981/#review13273 ----------------------------------------------------------- On Nov. 9, 2012, 12:29 a.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7981/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2012, 12:29 a.m.) > > > Review request for giraph. > > > Description > ------- > > GIRAPH-416: MasterObserver for user post-application customization > > > Diffs > ----- > > giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java > 496bce7e13cd282337d8bfd8526a25657316ea33 > > giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.java > bb6a739749d6110faf0a39f1b3bfee769bea28a2 > giraph/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java > 688ce4389a9b5ab6ed3d124af92936286563f21d > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java > 7d5dabb9df619b82dd42ab631b3c244fbdd9ddcf > giraph/src/main/java/org/apache/giraph/graph/IntNullNullNullVertex.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/graph/MasterThread.java > 5c9a72d5edbaafddca1f5050131a1657e15f5ac2 > > giraph/src/main/java/org/apache/giraph/io/IntNullNullNullTextInputFormat.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/master/MasterObserver.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/master/package-info.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java > b891690474ba2b64ed2778c332a7855565a64e5b > giraph/src/test/java/org/apache/giraph/TestGiraphConfiguration.java > PRE-CREATION > giraph/src/test/java/org/apache/giraph/TestMasterObserver.java PRE-CREATION > > Diff: https://reviews.apache.org/r/7981/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
