----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/#review13368 -----------------------------------------------------------
Ship it! +1, thanks Nitay. - Maja Kabiljo On Nov. 12, 2012, 6:59 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7980/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2012, 6:59 p.m.) > > > Review request for giraph. > > > Description > ------- > > GIRAPH-415: Refactor / cleanup Hadoop Counters > > > Diffs > ----- > > giraph/src/main/java/org/apache/giraph/counters/GiraphHadoopCounter.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/counters/GiraphStats.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/counters/GiraphTimers.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/counters/HadoopCountersBase.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/counters/package-info.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java 7d5dabb > giraph/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 8801dde > giraph/src/main/java/org/apache/giraph/graph/HashMapVertex.java 26b14ca > giraph/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java > a23b87f > > giraph/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java > 1db6e97 > giraph/src/main/java/org/apache/giraph/graph/MasterThread.java 5c9a72d > giraph/src/main/java/org/apache/giraph/graph/SimpleMutableVertex.java > 85af970 > giraph/src/main/java/org/apache/giraph/graph/SimpleVertex.java ed6759a > giraph/src/main/java/org/apache/giraph/graph/Vertex.java 8789ee5 > giraph/src/main/java/org/apache/giraph/metrics/EmptyMetricsRegistry.java > 262db29 > giraph/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java > eac9f72 > giraph/src/main/java/org/apache/giraph/metrics/NoOpMetricsRegistry.java > PRE-CREATION > giraph/src/main/java/org/apache/giraph/metrics/package-info.java f7529f5 > > Diff: https://reviews.apache.org/r/7980/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
