> On Nov. 19, 2012, 11:08 p.m., Avery Ching wrote: > > /trunk/pom.xml, lines 791-800 > > <https://reviews.apache.org/r/8034/diff/1/?file=188999#file188999line791> > > > > Just to verify, this doesn't include the hive jars in giraph, only the > > giraph-contrib-formats?
Yes, this just declares the package versions. Only giraph-formats-contrib has Hive has a dependency. - Alessandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8034/#review13580 ----------------------------------------------------------- On Nov. 20, 2012, 12:11 a.m., Alessandro Presta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8034/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2012, 12:11 a.m.) > > > Review request for giraph. > > > Description > ------- > > Edge-based input from HCatalog > > > This addresses bug GIRAPH-405. > https://issues.apache.org/jira/browse/GIRAPH-405 > > > Diffs > ----- > > /trunk/giraph-formats-contrib/pom.xml 1410684 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/GiraphHCatInputFormat.java > PRE-CREATION > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogEdgeInputFormat.java > PRE-CREATION > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java > 1410684 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexOutputFormat.java > 1410684 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexValueInputFormat.java > PRE-CREATION > > /trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HiveGiraphRunner.java > 1410684 > > /trunk/giraph-formats-contrib/src/main/java/org/apache/hcatalog/mapreduce/HCatUtils.java > PRE-CREATION > > /trunk/giraph-formats-contrib/src/main/java/org/apache/hcatalog/mapreduce/package-info.java > PRE-CREATION > /trunk/pom.xml 1410684 > > Diff: https://reviews.apache.org/r/8034/diff/ > > > Testing > ------- > > - mvn verify > - tested on a real application that runs on top of Hive > > > Thanks, > > Alessandro Presta > >
