[
https://issues.apache.org/jira/browse/GIRAPH-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509930#comment-13509930
]
Avery Ching commented on GIRAPH-441:
------------------------------------
+1, only minor comment would be to change the comment in NettyServer.java to be
a bit more verbose, since it maybe not be clear why this is important. Here is
an example (you can change it however you like of course)
// Store all connected channels
->
// Store all connected channels in order to ensure that we can close them on
stop(), or else stop() may hang waiting for the connections to close on their
own.
> Keep track of connected channels in NettyServer
> -----------------------------------------------
>
> Key: GIRAPH-441
> URL: https://issues.apache.org/jira/browse/GIRAPH-441
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Attachments: GIRAPH-441.patch
>
>
> We are still getting a timeout in NettyServer.stop(). We are not calling
> close on all the connected channels since we are not keeping track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
