----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8417/#review14184 -----------------------------------------------------------
Ship it! Thanks, Avery. Looks good overall. Two minor comments, but this is +1 from me. http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java <https://reviews.apache.org/r/8417/#comment30298> This value tells us how often to recheck the worker list, there is no continuing, please revisit the comment. http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java <https://reviews.apache.org/r/8417/#comment30297> Maybe rename this variable - it's the moment in which we want to give up, not the number of msecs left. - Maja Kabiljo On Dec. 7, 2012, 7:04 p.m., Avery Ching wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8417/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 7:04 p.m.) > > > Review request for giraph. > > > Description > ------- > > Added a 10 minute default for waiting for workers to join a superstep. > > > This addresses bug GIRAPH-446. > https://issues.apache.org/jira/browse/GIRAPH-446 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java > 1417641 > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java > 1417641 > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspServiceWorker.java > 1417641 > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/BspCase.java > 1417641 > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestAutoCheckpoint.java > 1417641 > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java > 1417641 > > Diff: https://reviews.apache.org/r/8417/diff/ > > > Testing > ------- > > Passed unittests. Ran on a cluster and saw observed the behavior working > correctly. > > > Thanks, > > Avery Ching > >
