[
https://issues.apache.org/jira/browse/GIRAPH-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527596#comment-13527596
]
Hudson commented on GIRAPH-444:
-------------------------------
Integrated in Giraph-trunk-Commit #305 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/305/])
GIRAPH-444: Cleanup VertexResolver (nitay) (Revision 1419098)
Result = SUCCESS
nitay : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1419098
Files :
* /giraph/trunk/CHANGELOG
*
/giraph/trunk/giraph-formats-contrib/src/main/java/org/apache/giraph/io/hcatalog/HCatalogEdgeInputFormat.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/GiraphConfiguration.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/GraphStateAware.java
*
/giraph/trunk/giraph/src/main/java/org/apache/giraph/ImmutableClassesGiraphConfiguration.java
*
/giraph/trunk/giraph/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java
*
/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BspUtils.java
*
/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/DefaultVertexResolver.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphJob.java
*
/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/GiraphTypeValidator.java
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/VertexResolver.java
*
/giraph/trunk/giraph/src/main/java/org/apache/giraph/utils/ReflectionUtils.java
* /giraph/trunk/giraph/src/test/java/org/apache/giraph/TestVertexTypes.java
> Cleanup VertexResolver
> ----------------------
>
> Key: GIRAPH-444
> URL: https://issues.apache.org/jira/browse/GIRAPH-444
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Labels: easy
> Attachments: GIRAPH-444.patch
>
>
> Few minor but necessary touchups to VertexResolver:
> 1) We're using VertexResolver in a bunch of places when we should be using
> BasicVertexResolver (the interface). On that note seems to me these two names
> should be flipped, that is VertexResolver should be the interface and
> BasicVertexResolver the default implementation. Thoughts?
> 2) Add GraphStateConfigurable interface similar to Configurable.
> 3) Add a boolean option for user to control whether to create vertex for a
> vertex that didn't exist but got messages. Need this for an algorithm I'm
> working on and seems to me to be general enough of a decision that we should
> allow user to control it.
> 4) General cleanup of VertexResolver logic into separate functions (no logic
> change).
> https://reviews.apache.org/r/8370/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
