Nitay Joffe created GIRAPH-447:
----------------------------------
Summary: Cleanup Configuration related things
Key: GIRAPH-447
URL: https://issues.apache.org/jira/browse/GIRAPH-447
Project: Giraph
Issue Type: Improvement
Reporter: Nitay Joffe
Assignee: Nitay Joffe
Priority: Minor
In this diff:
1) Create a conf/ package for configuration related things.
2) Create a GiraphClasses object from members of
ImmutableClassesGiraphConfiguration. Use this class inside
ImmutableClassesGiraphConfiguration itself.
3) Use GiraphClasses in tests to cleanup InternalVertexRunner, BspCase. Removes
a lot of methods with many parameters. Makes things more type safe. Removes a
lot of nulls in calling code.
4) Extract constants from GiraphConfiguration out into separate
GiraphConstants. Personally I think these constants should be moved to the
place where they are used (i.e. have ZKManager hold its configuration related
constants), but I think this is a step in the right direction.
Generally makes things cleaner IMO.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
