[
https://issues.apache.org/jira/browse/GIRAPH-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta reopened GIRAPH-450:
--------------------------------------
Still having this problem.
With a clean checkout, running "post-review" gives me this error:
{code}
Failed to execute command: ['git', 'config', 'core.bare']
{code}
If I add "bare = false" in ".git/config", "post-review -n" works but
"post-review" fails with:
{code}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
{code}
Who can help us fix this?
> post-review not working after switch to git
> -------------------------------------------
>
> Key: GIRAPH-450
> URL: https://issues.apache.org/jira/browse/GIRAPH-450
> Project: Giraph
> Issue Type: Bug
> Reporter: Alessandro Presta
> Assignee: Nitay Joffe
> Attachments: GIRAPH-450.patch
>
>
> After switching to pure git, post-review is left misconfigured.
> I managed to produce a patch with "post-review -n
> --tracking-branch=origin/trunk" after adding "bare = false" under "[core]" in
> ".git/config".
> However, the same didn't work for updating a review on ReviewBoard.
> We need to fix the configuration so this works out of the box.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
