[
https://issues.apache.org/jira/browse/GIRAPH-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544359#comment-13544359
]
Hudson commented on GIRAPH-409:
-------------------------------
Integrated in Giraph-trunk-Commit #540 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/540/])
GIRAPH-409: Refactor / cleanups (nitay) (Revision
1684891ecf471cc7d52c95b187fcf290f7e1ce14)
Result = SUCCESS
nitay :
http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=1684891ecf471cc7d52c95b187fcf290f7e1ce14
Files :
*
giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyMasterClient.java
* giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertexResolver.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/BasicPartitionOwner.java
* giraph-core/src/main/java/org/apache/giraph/partition/ByteArrayPartition.java
*
giraph-core/src/main/java/org/apache/giraph/examples/AggregatorsTestVertex.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionStore.java
*
giraph-core/src/main/java/org/apache/giraph/graph/RepresentativeVertexBase.java
*
giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToMasterRequest.java
* giraph-core/src/main/java/org/apache/giraph/utils/Time.java
* giraph-core/src/test/java/org/apache/giraph/graph/TestAggregatorsHandling.java
*
giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/bsp/BspOutputFormat.java
*
giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/Combiner.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/PartitionOwner.java
* giraph-core/src/main/java/org/apache/giraph/comm/MasterClient.java
*
giraph-core/src/main/java/org/apache/giraph/io/PseudoRandomVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/GiraphFileInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/TextEdgeInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/vertex/MultiGraphEdgeListVertex.java
* giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankComputation.java
* giraph-core/src/main/java/org/apache/giraph/master/package-info.java
* giraph-core/src/test/java/org/apache/giraph/TestVertexTypes.java
*
giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java
*
giraph-core/src/main/java/org/apache/giraph/io/JsonLongDoubleFloatDoubleVertexOutputFormat.java
* giraph-core/src/test/java/org/apache/giraph/conf/TestGiraphConfiguration.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/WorkerAggregatorHandler.java
*
giraph-core/src/main/java/org/apache/giraph/partition/MasterGraphPartitioner.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/partition/package-info.java
* giraph-core/src/main/java/org/apache/giraph/partition/Partition.java
* giraph-core/src/main/java/org/apache/giraph/combiner/package-info.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/Aggregator.java
*
giraph-core/src/main/java/org/apache/giraph/worker/InputSplitPathOrganizer.java
* giraph-core/src/test/java/org/apache/giraph/TestPredicateLock.java
*
giraph-core/src/main/java/org/apache/giraph/io/JsonBase64VertexOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java
*
giraph-core/src/main/java/org/apache/giraph/comm/aggregators/OwnerAggregatorServerData.java
* giraph-core/src/main/java/org/apache/giraph/io/package-info.java
* giraph-core/src/test/java/org/apache/giraph/examples/TestPageRank.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/EdgeListVertexPageRankBenchmark.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/HashMapVertexPageRankBenchmark.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/MasterRequestServerHandler.java
*
giraph-core/src/main/java/org/apache/giraph/graph/InputSplitsCallableFactory.java
*
giraph-core/src/main/java/org/apache/giraph/vertex/RepresentativeVertexBase.java
* giraph-core/src/main/java/org/apache/giraph/utils/Times.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexMutations.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleInDegreeCountVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/EdgeInputSplitsCallableFactory.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
*
giraph-core/src/main/java/org/apache/giraph/vertex/LongDoubleNullDoubleVertex.java
* giraph-core/src/main/java/org/apache/giraph/vertex/SimpleVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexValueInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/BasicAggregator.java
* giraph-core/src/main/java/org/apache/giraph/graph/GiraphTransferRegulator.java
*
giraph-core/src/main/java/org/apache/giraph/graph/VertexInputSplitsCallableFactory.java
*
giraph-core/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java
* giraph-core/src/main/java/org/apache/giraph/vertex/MutableVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/PartitionUtils.java
* giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java
* giraph-core/src/main/java/org/apache/giraph/examples/IdentityVertex.java
*
giraph-core/src/main/java/org/apache/giraph/io/AdjacencyListTextVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/WorkerAggregatorUsage.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexValueInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/MultiGraphEdgeListVertexPageRankBenchmark.java
* giraph-core/src/main/java/org/apache/giraph/combiner/SimpleSumCombiner.java
* giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
*
giraph-core/src/main/java/org/apache/giraph/graph/WorkerThreadAggregatorUsage.java
*
giraph-core/src/main/java/org/apache/giraph/worker/WorkerAggregatorHandler.java
*
giraph-core/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
*
giraph-core/src/main/java/org/apache/giraph/partition/HashMasterPartitioner.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/GeneratedVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/JsonBase64VertexOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/RangePartitionStats.java
*
giraph-core/src/main/java/org/apache/giraph/examples/VertexWithDoubleValueFloatEdgeTextOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java
* giraph-core/src/test/java/org/apache/giraph/graph/TestMultiGraphVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/GiraphInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/AdjacencyListTextVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/EdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/BasicVertexValueReader.java
* giraph-core/src/main/java/org/apache/giraph/io/TextVertexValueInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/SimplePartition.java
* giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java
*
giraph-core/src/main/java/org/apache/giraph/io/PseudoRandomEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/master/MasterAggregatorUsage.java
* giraph-core/src/main/java/org/apache/giraph/graph/RepresentativeVertex.java
* giraph-core/src/main/java/org/apache/giraph/time/package-info.java
* giraph-core/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntTextVertexValueInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/DiskBackedPartitionStore.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
* giraph-core/src/main/java/org/apache/giraph/combiner/MinimumIntCombiner.java
*
giraph-core/src/main/java/org/apache/giraph/examples/LongDoubleFloatDoubleTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/partition/RangeSplitHint.java
* giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedService.java
* CHANGELOG
* giraph-core/src/main/java/org/apache/giraph/graph/EdgeInputSplitsCallable.java
* giraph-core/src/test/java/org/apache/giraph/TestEdgeInput.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/HashRangeWorkerPartitioner.java
* giraph-core/src/main/java/org/apache/giraph/time/SystemTime.java
* giraph-core/src/main/java/org/apache/giraph/zk/PredicateLock.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestEncoder.java
* giraph-core/src/main/java/org/apache/giraph/partition/RangePartitionStats.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/combiner/DoubleSumCombiner.java
* giraph-core/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* giraph-core/src/main/java/org/apache/giraph/master/MasterInfo.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionStats.java
*
giraph-core/src/main/java/org/apache/giraph/examples/MinimumDoubleCombiner.java
*
giraph-core/src/main/java/org/apache/giraph/comm/aggregators/AllAggregatorServerData.java
* giraph-core/src/main/java/org/apache/giraph/graph/MutableVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/PartitionBalancer.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexInputFormat.java
*
giraph-accumulo/src/main/java/org/apache/giraph/io/accumulo/AccumuloVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/HashMapVertex.java
* giraph-core/src/main/java/org/apache/giraph/bsp/BspUtils.java
* giraph-core/src/test/java/org/apache/giraph/utils/BspUtilsTest.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/AggregatorsBenchmark.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestDecoder.java
* giraph-core/src/main/java/org/apache/giraph/graph/GiraphTypeValidator.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/MasterGraphPartitioner.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java
* giraph-core/src/main/java/org/apache/giraph/time/Times.java
* giraph-core/src/main/java/org/apache/giraph/graph/MasterThread.java
* giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java
* giraph-core/src/main/java/org/apache/giraph/graph/AggregatorWriter.java
* giraph-core/src/main/java/org/apache/giraph/graph/MasterAggregatorUsage.java
*
giraph-core/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java
*
giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientRequestProcessor.java
* giraph-core/src/main/java/org/apache/giraph/comm/SendPartitionCache.java
*
giraph-core/src/test/java/org/apache/giraph/partition/TestGiraphTransferRegulator.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/AggregatorWrapper.java
* giraph-core/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/PartitionExchange.java
* giraph-core/src/main/java/org/apache/giraph/io/JsonBase64VertexFormat.java
* giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java
* giraph-core/src/main/java/org/apache/giraph/graph/MasterInfo.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/HashPartitionerFactory.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
* giraph-core/src/main/java/org/apache/giraph/vertex/EdgeListVertexBase.java
*
giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionOwner.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/AdjacencyListTextVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/worker/WorkerAggregatorUsage.java
* giraph-core/src/main/java/org/apache/giraph/comm/WorkerClient.java
*
giraph-core/src/main/java/org/apache/giraph/partition/RangeWorkerPartitioner.java
* giraph-core/src/test/java/org/apache/giraph/vertex/TestMutableVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java
*
giraph-core/src/test/java/org/apache/giraph/graph/partition/TestGiraphTransferRegulator.java
*
giraph-hbase/src/main/java/org/apache/giraph/io/hbase/HBaseVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java
*
giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeOutputFormat.java
* giraph-core/src/test/java/org/apache/giraph/TestJsonBase64Format.java
* giraph-core/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphFileInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsComputation.java
* giraph-core/src/test/java/org/apache/giraph/TestMasterObserver.java
* giraph-core/src/test/java/org/apache/giraph/zk/TestPredicateLock.java
*
giraph-core/src/main/java/org/apache/giraph/graph/MultiGraphRepresentativeVertex.java
* giraph-core/src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java
*
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
* giraph-core/src/main/java/org/apache/giraph/metrics/GiraphTimerContext.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/SimplePartitionStore.java
*
giraph-core/src/main/java/org/apache/giraph/worker/WorkerThreadAggregatorUsage.java
* giraph-core/src/main/java/org/apache/giraph/graph/Aggregator.java
*
giraph-core/src/main/java/org/apache/giraph/partition/HashRangeWorkerPartitioner.java
* giraph-core/src/main/java/org/apache/giraph/io/TextEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/WorkerContext.java
*
giraph-accumulo/src/main/java/org/apache/giraph/io/accumulo/AccumuloVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/IdWithValueTextOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/AggregatorWrapper.java
*
giraph-core/src/main/java/org/apache/giraph/io/IntNullNullNullTextInputFormat.java
*
giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexValueInputFormat.java
* giraph-core/src/test/java/org/apache/giraph/zk/TestZooKeeperExt.java
* giraph-core/src/main/java/org/apache/giraph/partition/package-info.java
* giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleEdgeListVertex.java
* giraph-core/src/test/java/org/apache/giraph/TestGraphPartitioner.java
* giraph-core/src/test/java/org/apache/giraph/bsp/BspUtilsTest.java
* giraph-core/src/main/java/org/apache/giraph/graph/IntNullNullNullVertex.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestInfo.java
*
giraph-core/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java
*
giraph-core/src/main/java/org/apache/giraph/io/LongDoubleDoubleAdjacencyListVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/comm/requests/SendVertexRequest.java
* giraph-core/src/main/java/org/apache/giraph/time/FakeTime.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/LongDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/GeneratedVertexInputFormat.java
* giraph-core/src/test/java/org/apache/giraph/comm/TestMessageStores.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
*
giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HiveGiraphRunner.java
* giraph-core/src/main/java/org/apache/giraph/io/EdgeReader.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexResolver.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleMasterComputeVertex.java
* giraph-core/src/main/java/org/apache/giraph/vertex/SimpleMutableVertex.java
*
giraph-core/src/main/java/org/apache/giraph/comm/aggregators/AggregatorUtils.java
* giraph-core/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
*
giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallableFactory.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/TextDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/partition/BasicPartitionOwner.java
* giraph-core/src/main/java/org/apache/giraph/worker/DefaultWorkerContext.java
*
giraph-core/src/main/java/org/apache/giraph/metrics/SuperstepMetricsRegistry.java
*
giraph-core/src/test/java/org/apache/giraph/graph/partition/TestPartitionStores.java
* giraph-core/src/main/java/org/apache/giraph/vertex/package-info.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionBalancer.java
* giraph-core/src/main/java/org/apache/giraph/graph/MasterCompute.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/RepresentativeVertexPageRankBenchmark.java
*
giraph-core/src/test/java/org/apache/giraph/io/TestAdjacencyListTextVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/IntNullTextEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java
*
giraph-core/src/main/java/org/apache/giraph/comm/aggregators/SendAggregatorCache.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java
* giraph-core/src/main/java/org/apache/giraph/io/GiraphTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/vertex/Vertex.java
* giraph-core/src/main/java/org/apache/giraph/GiraphRunner.java
* giraph-core/src/main/java/org/apache/giraph/graph/BspUtils.java
* giraph-core/src/test/java/org/apache/giraph/TestBspBasic.java
* giraph-core/src/test/java/org/apache/giraph/utils/MockUtils.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/PartitionStore.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleTriangleClosingVertex.java
*
giraph-core/src/main/java/org/apache/giraph/io/JsonBase64VertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/partition/RangePartitionerFactory.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/WorkerGraphPartitioner.java
*
giraph-core/src/main/java/org/apache/giraph/graph/VertexInputSplitsCallable.java
* giraph-core/src/test/java/org/apache/giraph/TestPageRank.java
* giraph-core/src/main/java/org/apache/giraph/graph/GraphMapper.java
* giraph-core/src/main/java/org/apache/giraph/utils/FakeTime.java
* giraph-core/src/test/java/org/apache/giraph/zk/TestZooKeeperManager.java
* giraph-core/src/main/java/org/apache/giraph/io/BasicVertexValueReader.java
* giraph-core/src/main/java/org/apache/giraph/graph/DefaultWorkerContext.java
*
giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToWorkerRequest.java
*
giraph-core/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetrics.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/JsonBase64VertexFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java
*
giraph-core/src/test/java/org/apache/giraph/vertex/TestIntIntNullIntVertex.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/ByteCounter.java
* giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java
* giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java
*
giraph-core/src/main/java/org/apache/giraph/io/TextDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/GiraphInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/HashRangePartitionerFactory.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/HashMasterPartitioner.java
*
giraph-core/src/main/java/org/apache/giraph/partition/HashWorkerPartitioner.java
* giraph-core/src/main/java/org/apache/giraph/examples/DoubleSumCombiner.java
*
giraph-core/src/main/java/org/apache/giraph/partition/GraphPartitionerFactory.java
* giraph-core/src/main/java/org/apache/giraph/partition/RangePartitionOwner.java
* giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java
* giraph-core/src/test/java/org/apache/giraph/graph/TestMutableVertex.java
* giraph-core/src/main/java/org/apache/giraph/io/formats/package-info.java
* giraph-core/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/PartitionStats.java
* giraph-core/src/test/java/org/apache/giraph/TestZooKeeperExt.java
* giraph-core/src/main/java/org/apache/giraph/aggregators/AggregatorWriter.java
*
giraph-core/src/main/java/org/apache/giraph/io/AdjacencyListTextVertexOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/IntIntTextVertexValueInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallableFactory.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomEdgeInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/comm/requests/SendAggregatorsToOwnerRequest.java
* giraph-core/src/main/java/org/apache/giraph/vertex/HashMapVertex.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerAggregatorRequestProcessor.java
* giraph-core/src/main/java/org/apache/giraph/graph/WorkerInfo.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexWriter.java
*
giraph-core/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexWriter.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/IntNullTextEdgeInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/comm/aggregators/AggregatorOutputStream.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
*
giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/RangePartitionerFactory.java
* giraph-core/src/main/java/org/apache/giraph/vertex/IntIntNullIntVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexReader.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullIntTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexValueReader.java
* giraph-core/src/main/java/org/apache/giraph/graph/InputSplitPathOrganizer.java
* giraph-core/src/main/java/org/apache/giraph/vertex/EdgeListVertex.java
* giraph-core/src/main/java/org/apache/giraph/master/DefaultMasterCompute.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/RangeWorkerPartitioner.java
* giraph-core/src/main/java/org/apache/giraph/vertex/IntNullNullNullVertex.java
* giraph-core/src/main/java/org/apache/giraph/metrics/AggregatedMetrics.java
*
giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java
* giraph-core/src/main/java/org/apache/giraph/master/MasterThread.java
*
giraph-core/src/main/java/org/apache/giraph/partition/HashPartitionerFactory.java
* giraph-core/src/test/java/org/apache/giraph/comm/ConnectionTest.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/GiraphJob.java
*
giraph-core/src/main/java/org/apache/giraph/partition/WorkerGraphPartitioner.java
* giraph-core/src/main/java/org/apache/giraph/worker/package-info.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleOutDegreeCountVertex.java
* giraph-core/src/test/java/org/apache/giraph/graph/TestIntIntNullIntVertex.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/IntNullNullNullTextInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.java
* giraph-core/src/main/java/org/apache/giraph/master/MasterCompute.java
*
giraph-core/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleFloatDoubleTextInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/partition/HashRangePartitionerFactory.java
*
giraph-core/src/main/java/org/apache/giraph/partition/SimplePartitionStore.java
* giraph-core/src/main/java/org/apache/giraph/combiner/Combiner.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClient.java
* giraph-core/src/main/java/org/apache/giraph/graph/SimpleVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/GlobalStats.java
*
giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkWorkerContext.java
* giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceMaster.java
* giraph-core/src/main/java/org/apache/giraph/comm/MsgList.java
*
giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java
* giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java
* giraph-core/src/main/java/org/apache/giraph/graph/SimpleMutableVertex.java
*
giraph-core/src/main/java/org/apache/giraph/aggregators/TextAggregatorWriter.java
* giraph-core/src/main/java/org/apache/giraph/graph/GraphState.java
* giraph-core/src/main/java/org/apache/giraph/comm/requests/MasterRequest.java
* giraph-core/src/main/java/org/apache/giraph/bsp/ImmutableOutputCommitter.java
*
giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/MultiGraphRepresentativeVertexPageRankBenchmark.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/comm/WorkerClientServer.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/IdWithValueTextOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java
*
giraph-core/src/main/java/org/apache/giraph/vertex/LongDoubleFloatDoubleVertex.java
* giraph-core/src/main/java/org/apache/giraph/worker/WorkerContext.java
*
giraph-core/src/main/java/org/apache/giraph/integration/SuperstepHashPartitionerFactory.java
* giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java
*
giraph-core/src/main/java/org/apache/giraph/io/IntIntNullIntTextInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/HashMapVertexShortestPathsBenchmark.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/RangeMasterPartitioner.java
* giraph-core/src/main/java/org/apache/giraph/graph/BspService.java
*
giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallableFactory.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/JsonBase64VertexInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/examples/VerifyMessage.java
* giraph-core/src/main/java/org/apache/giraph/graph/partition/Partition.java
* giraph-core/src/main/java/org/apache/giraph/graph/InputSplitsCallable.java
* giraph-core/src/main/java/org/apache/giraph/io/TextVertexOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/SequenceFileVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java
* giraph-core/src/main/java/org/apache/giraph/graph/EdgeListVertexBase.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/ByteArrayPartition.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/RangePartitionOwner.java
*
giraph-core/src/main/java/org/apache/giraph/combiner/MinimumDoubleCombiner.java
* giraph-core/src/main/java/org/apache/giraph/graph/MasterAggregatorHandler.java
* giraph-core/src/main/java/org/apache/giraph/graph/IntIntNullIntVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/DefaultMasterCompute.java
* giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java
* giraph-core/src/main/java/org/apache/giraph/worker/WorkerInfo.java
*
giraph-core/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java
*
giraph-hbase/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java
*
giraph-core/src/main/java/org/apache/giraph/vertex/MultiGraphRepresentativeVertex.java
* giraph-core/src/main/java/org/apache/giraph/io/TextVertexInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/partition/RangeMasterPartitioner.java
*
giraph-core/src/main/java/org/apache/giraph/graph/LongDoubleNullDoubleVertex.java
* giraph-core/src/test/java/org/apache/giraph/TestGiraphConfiguration.java
*
giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionExchange.java
*
giraph-core/src/main/java/org/apache/giraph/examples/ConnectedComponentsVertex.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleAggregatorWriter.java
*
giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* giraph-core/src/main/java/org/apache/giraph/graph/VertexChanges.java
* giraph-core/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java
* giraph-core/src/main/java/org/apache/giraph/time/Time.java
* giraph-core/src/test/java/org/apache/giraph/BspCase.java
* giraph-core/src/main/java/org/apache/giraph/vertex/RepresentativeVertex.java
*
giraph-core/src/main/java/org/apache/giraph/vertex/LongDoubleFloatDoubleEdgeListVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/RangeSplitHint.java
* giraph-core/src/main/java/org/apache/giraph/utils/SystemTime.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleTextVertexOutputFormat.java
* giraph-core/src/main/java/org/apache/giraph/io/VertexValueInputFormat.java
* giraph-core/src/test/java/org/apache/giraph/vertex/TestMultiGraphVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/Vertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/EdgeReader.java
* giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java
*
giraph-core/src/main/java/org/apache/giraph/graph/partition/GraphPartitionerFactory.java
* giraph-core/src/main/java/org/apache/giraph/comm/SendMutationsCache.java
*
giraph-core/src/main/java/org/apache/giraph/master/MasterAggregatorHandler.java
*
giraph-core/src/main/java/org/apache/giraph/graph/MultiGraphEdgeListVertex.java
* giraph-core/src/main/java/org/apache/giraph/graph/EdgeInputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
*
giraph-core/src/main/java/org/apache/giraph/graph/AddressesAndPartitionsWritable.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionUtils.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/RandomMessageBenchmark.java
*
giraph-hbase/src/main/java/org/apache/giraph/io/hbase/HBaseVertexOutputFormat.java
*
giraph-core/src/main/java/org/apache/giraph/io/JsonLongDoubleFloatDoubleVertexInputFormat.java
*
giraph-core/src/test/java/org/apache/giraph/io/TestIdWithValueTextOutputFormat.java
> Refactor / cleanups
> -------------------
>
> Key: GIRAPH-409
> URL: https://issues.apache.org/jira/browse/GIRAPH-409
> Project: Giraph
> Issue Type: Improvement
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Attachments: GIRAPH-409.patch
>
>
> Some general thoughts I've jotted down while going through the code. Writing
> them here to start tracking progress for them.
> 1. Refactor giraph.graph to giraph.master, giraph.worker. The whole
> giraph.graph package name is bad in general I think.
> 2. Cleanup giraph.utils. For example move timers stuff to giraph.time.
> 3. Change module names to be more maven-esque, that is something like
> giraph-root, giraph-core, giraph-formats.
> 4. Remove WorkerClientServer. Is this needed anymore?
> 5. Cleanup MasterThread#run: long convoluted method.
> 6. Cleanup BspService#process: lots of duplication. Use a vector of events or
> something.
> 7. Cleanup Vertex class: seems to me it has too many methods and should be a
> simpler interface (maybe even eventually an actual interface! not an abstract
> class). Add something like a Vertexes/Vertices class with helper methods that
> use can use.
> 8. {Master,Worker}Observer. Discussed elsewhere already. ALlow users to
> easily plug in code at various points in the system. Essentially a cleaner
> implementation of e.g. WorkerContext
> 9. Cleanup GraphMapper. I don't see why we even call a map() method seeing as
> we are overriding run(). We are clearly not particularly "mapreduce-y" so we
> should make it our entry point more clear than a map(). Also I think we
> should have something like a WorkerThread similar to MasterThread and clean
> up all of this to just creare whichever threads the node is assigned roles
> of.
> 10. Move examples and anything else not needed for a giraph library out into
> it's own package (like giraph-examples)?
> If someone +1s the ideas I'll work up some patches. Feel free to add other
> cleanup things here as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
