[ 
https://issues.apache.org/jira/browse/GIRAPH-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547447#comment-13547447
 ] 

Alessandro Presta commented on GIRAPH-473:
------------------------------------------

Hey Eli, I was sure "mvn verify" was passing earlier, but re-running it again I 
get a failure now.
I have a question for you: in TestBspBasic#testInputSplitPathOrganizer(), what 
is the point of "good", "bad", "ugly"?
To me it looks like "good" is the local split, "bad" and "ugly" are both 
non-local, but there is no order of preference between the two.
Am I right?
If that's the case, we should just be checking that "good" comes first.
                
> InputSplitPathOrganizer should be aware of multiple threads
> -----------------------------------------------------------
>
>                 Key: GIRAPH-473
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-473
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-473.patch
>
>
> The starting offset for iterating over input splits is obtained by hashing 
> the worker's hostname and port. When multiple input threads are used, they 
> get the same offset.
> We should hash the thread id as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to