----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9103/ -----------------------------------------------------------
Review request for giraph. Summary (updated) ----------------- Create Examples Maven project Description (updated) ------- Basically a new maven project was created to hold all the examples package from the Core project (https://issues.apache.org/jira/browse/GIRAPH-470). I had to refactor the Algorithm class in Core project because it was located inside examples package. Also all tests related to examples were moved to the Examples project. Unfortunately some tests that are related to Core had to be moved since they depend on Examples code. A final refactor would be nice to separate these tests but didn't do it because I considered that was an unrelated task. There is, although, a task related to this problem https://issues.apache.org/jira/browse/GIRAPH-365. Diffs ----- giraph-core/pom.xml b0c51b5 giraph-core/src/main/java/org/apache/giraph/Algorithm.java PRE-CREATION giraph-core/src/main/java/org/apache/giraph/GiraphRunner.java 2e88a83 giraph-core/src/main/java/org/apache/giraph/examples/AggregatorsTestVertex.java c00fda0 giraph-core/src/main/java/org/apache/giraph/examples/Algorithm.java 57d5011 giraph-core/src/main/java/org/apache/giraph/examples/ConnectedComponentsVertex.java b5c90e5 giraph-core/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java 26f970d giraph-core/src/main/java/org/apache/giraph/examples/IdentityVertex.java 7000035 giraph-core/src/main/java/org/apache/giraph/examples/LongDoubleFloatDoubleTextInputFormat.java 53e83a4 giraph-core/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleFloatDoubleTextInputFormat.java 65bc636 giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkVertex.java 3c0abe7 giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkWithRestartVertex.java 8a689ed giraph-core/src/main/java/org/apache/giraph/examples/RandomWalkWorkerContext.java 5cff23f giraph-core/src/main/java/org/apache/giraph/examples/SimpleAggregatorWriter.java 1887621 giraph-core/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java b23a163 giraph-core/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex.java be0f16c giraph-core/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java 521ed97 giraph-core/src/main/java/org/apache/giraph/examples/SimpleInDegreeCountVertex.java 605d9d5 giraph-core/src/main/java/org/apache/giraph/examples/SimpleLongDoubleDoubleDoubleIdentityVertex.java c7349d1 giraph-core/src/main/java/org/apache/giraph/examples/SimpleMasterComputeVertex.java e481ff7 giraph-core/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java 8016490 giraph-core/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java 5d7deb7 giraph-core/src/main/java/org/apache/giraph/examples/SimpleOutDegreeCountVertex.java 1e010a1 giraph-core/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java c3b79b4 giraph-core/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java 1bec7eb giraph-core/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java 2837a57 giraph-core/src/main/java/org/apache/giraph/examples/SimpleTextVertexOutputFormat.java a57c6d2 giraph-core/src/main/java/org/apache/giraph/examples/SimpleTriangleClosingVertex.java 484dd8a giraph-core/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java b7605bb giraph-core/src/main/java/org/apache/giraph/examples/VerifyMessage.java 2914360 giraph-core/src/main/java/org/apache/giraph/examples/VertexWithDoubleValueFloatEdgeTextOutputFormat.java ef58bb8 giraph-core/src/main/java/org/apache/giraph/examples/package-info.java 3ebb72b giraph-core/src/test/java/org/apache/giraph/BspCase.java f43efe9 giraph-core/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 87af297 giraph-core/src/test/java/org/apache/giraph/TestBspBasic.java 987f51c giraph-core/src/test/java/org/apache/giraph/TestGraphPartitioner.java ff71b86 giraph-core/src/test/java/org/apache/giraph/TestManualCheckpoint.java 7d3dde3 giraph-core/src/test/java/org/apache/giraph/TestMutateGraph.java 7bac9e8 giraph-core/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 7654305 giraph-core/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java 40db41f giraph-core/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java 49a2f33 giraph-core/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java 434c756 giraph-core/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java 4052fe1 giraph-core/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java 8037e9e giraph-core/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingVertexTest.java 6af7339 giraph-core/src/test/java/org/apache/giraph/examples/TestPageRank.java 3909f46 giraph-core/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java 2f9704d giraph-core/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java 1a260d5 giraph-examples/pom.xml PRE-CREATION giraph-examples/src/main/assembly/assembly.xml PRE-CREATION giraph-examples/src/main/assembly/compile.xml PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/AggregatorsTestVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/Algorithm.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/ConnectedComponentsVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/IdentityVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleFloatDoubleTextInputFormat.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleFloatDoubleTextInputFormat.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkWithRestartVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkWorkerContext.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleAggregatorWriter.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleCheckpointVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleCombinerVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleFailVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleInDegreeCountVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleLongDoubleDoubleDoubleIdentityVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleMasterComputeVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleMsgVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleOutDegreeCountVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleTextVertexOutputFormat.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleTriangleClosingVertex.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/SimpleVertexWithWorkerContext.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/VerifyMessage.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/VertexWithDoubleValueFloatEdgeTextOutputFormat.java PRE-CREATION giraph-examples/src/main/java/org/apache/giraph/examples/package-info.java PRE-CREATION giraph-examples/src/site/resources/css/site.css PRE-CREATION giraph-examples/src/site/resources/images/ApacheGiraph.svg PRE-CREATION giraph-examples/src/site/site.xml PRE-CREATION giraph-examples/src/site/xdoc/index.xml PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/TestMutateGraph.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/MinimumIntCombinerTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/SimpleTriangleClosingVertexTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/utils/ComparisonUtilsTest.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/utils/MockUtils.java PRE-CREATION giraph-examples/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java PRE-CREATION pom.xml 88868ba Diff: https://reviews.apache.org/r/9103/diff/ Testing (updated) ------- All tests passed, at least here in my laptop. Thanks, Gustavo Salazar Torres
