[
https://issues.apache.org/jira/browse/GIRAPH-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609104#comment-13609104
]
Nitay Joffe commented on GIRAPH-576:
------------------------------------
Awesome looks great to me. Does it pass "mvn clean install"? I'm going to try
it on my box and commit.
> BspServiceMaster.failureCleanup() shouldn't pass null in observers'
> applicationFailed() method
> ----------------------------------------------------------------------------------------------
>
> Key: GIRAPH-576
> URL: https://issues.apache.org/jira/browse/GIRAPH-576
> Project: Giraph
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Environment: Linux
> Reporter: Jess Garms
> Priority: Minor
> Labels: easy, newbie, patch
> Fix For: 0.2.0
>
> Attachments: GIRAPH-576.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> failureCleanup() in BspServiceMaster gets called with a null exception from
> failJob(). That in turn passes a null exception to the set of
> MasterObservers, in their applicationFailed() method. They probably aren't
> expecting that. Instead we should pass an appropriate exception around
> depending on the cause of the failure.
> I'll attach a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
