-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10119/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Adds a VertexValueFactory that can be optionally specified by the user.
It's initialized with the configuration.
DefaultVertexValueFactory implements the current behavior (caches the vertex 
value class and uses reflection).


This addresses bug GIRAPH-586.
    https://issues.apache.org/jira/browse/GIRAPH-586


Diffs
-----

  giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java 
5090250d93ec73be34d0bd306d00704856a89785 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 
6886d5827b3aeece07bbf192390171dc17a05e1d 
  giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java 
ad9073d2431f4e065f373468a54cd2b9baa7c654 
  
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
 4fedc464ce08051cdadb49cc0ac2e8553093ce46 
  
giraph-core/src/main/java/org/apache/giraph/graph/DefaultVertexValueFactory.java
 PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/graph/VertexValueFactory.java 
PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java
 b08c74d42808790f1eb860183feed436b53c5275 
  giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 
41238d045c41c8292a8ea70ba899fa51cfe42480 
  giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 
7e0b955998a5f1890912819fa2ca74fbbf46fedd 
  giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 
55c0c86ee7f188d6624def8dd3002962631d6a3f 
  giraph-examples/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java 
c47c291e3102619319667ace594c18b7c6cb442b 

Diff: https://reviews.apache.org/r/10119/diff/


Testing
-------

mvn verify


Thanks,

Alessandro Presta

Reply via email to