----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10125/#review18363 -----------------------------------------------------------
Ship it! +1. Personally, I'd prefer it to be defined in terms of maximum number of supersteps (maps to the "iterations" parameter of many algorithms) instead of max superstep, but it's a matter of taste. - Alessandro Presta On March 25, 2013, 8:57 p.m., Avery Ching wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10125/ > ----------------------------------------------------------- > > (Updated March 25, 2013, 8:57 p.m.) > > > Review request for giraph. > > > Description > ------- > > If you set this option (giraph.maxSuperstep) to say 3, the application will > run superstep 3 and then shutdown. Note that the application can always > chose to halt earlier. This will allow us to get rid of some boilerplate > code in Vertex to halt on a given superstep (i.e page rank). > > > This addresses bug GIRAPH-582. > https://issues.apache.org/jira/browse/GIRAPH-582 > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java > 6886d5827b3aeece07bbf192390171dc17a05e1d > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java > ad9073d2431f4e065f373468a54cd2b9baa7c654 > giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java > 9188a234c854cabf918c771b1661540414231ea7 > giraph-examples/src/test/java/org/apache/giraph/TestMaxSuperstep.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/10125/diff/ > > > Testing > ------- > > Added a new unitteset TextMaxSuperstep. > mvn clean verify > > > Thanks, > > Avery Ching > >
