----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10149/#review18439 -----------------------------------------------------------
Ship it! Looks fine overall, +1. giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java <https://reviews.apache.org/r/10149/#comment38658> Make a constant for this option giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java <https://reviews.apache.org/r/10149/#comment38657> We can always reuse edges in edge input, so you can clean up this part (though no need if GIRAPH-588 is going to get in :-)) - Maja Kabiljo On March 27, 2013, 7:14 a.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10149/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 7:14 a.m.) > > > Review request for giraph. > > > Description > ------- > > https://issues.apache.org/jira/browse/GIRAPH-593 > > > Diffs > ----- > > giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java > efc08d30d0832f25c5805531562b133a3f9d6cf1 > giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveProfiles.java > b0ddc488b471d708931f586cfe36b67ae2031b9e > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/AbstractHiveToEdge.java > f29fea73e7aedd47386f70299d79313ad11f372a > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeInputFormat.java > 18b40c27c3c5476d5a34a2abf7dfb2c0475efb9a > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java > 6fb183a24ac1a5d1b82fca7a580df4841dbec43b > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveToEdge.java > 2205b82ee79138d7fa49340ca8ceeb2e919d56c4 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractHiveToVertexEdges.java > d0668f6f49f42d21eaeeff6d31d3c79ee0e5d038 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractHiveToVertexValue.java > 9ab316f5355251697f36977f4f9ff81c7ce2c3bf > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVertexEdges.java > 8076a8a5e31077bd67afbf277f9b8b7dcb2a55ec > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVertexValue.java > 593eb9a399ccf813795e9d0430f09460cf512f2c > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexInputFormat.java > 25c7a26b95f4084cda313ff2034f484f189ffb69 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexReader.java > 541176fe48f3837d8ea134ead106a9c5df315bc1 > > giraph-hive/src/main/java/org/apache/giraph/hive/output/AbstractVertexToHive.java > 8e3f1cab6f0d67f02ea71ac057a7763c2e1d3004 > > giraph-hive/src/main/java/org/apache/giraph/hive/output/HiveVertexOutputFormat.java > 641a2984ea4e34f671bc7817245338dbbc321f84 > > giraph-hive/src/main/java/org/apache/giraph/hive/output/HiveVertexWriter.java > a97d40aa371ac91278cca8c04ddcb6389e6badb6 > giraph-hive/src/main/java/org/apache/giraph/hive/output/VertexToHive.java > 6d323bdb1fc3148473f14d6613791d2b989cd67e > pom.xml e576e4b5e55be507225860e7d1c1fc55629f1761 > > Diff: https://reviews.apache.org/r/10149/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
