[
https://issues.apache.org/jira/browse/GIRAPH-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616775#comment-13616775
]
Hudson commented on GIRAPH-587:
-------------------------------
Integrated in Giraph-trunk-Commit #854 (See
[https://builds.apache.org/job/Giraph-trunk-Commit/854/])
GIRAPH-587: Refactor configuration options (nitay) (Revision
01c527e225336d68a30e447889b37b6187f6286c)
Result = FAILURE
nitay :
http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=01c527e225336d68a30e447889b37b6187f6286c
Files :
* giraph-core/src/main/java/org/apache/giraph/zk/ZooKeeperManager.java
* giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java
* giraph-core/src/main/java/org/apache/giraph/conf/AllOptions.java
* giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* giraph-core/src/main/java/org/apache/giraph/partition/SimplePartition.java
*
giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java
* giraph-core/src/main/java/org/apache/giraph/bsp/BspInputFormat.java
* giraph-core/src/main/java/org/apache/giraph/conf/StrConfOption.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestEncoder.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
* giraph-core/src/main/java/org/apache/giraph/comm/SendMessageCache.java
* giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java
*
giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/RequestServerHandler.java
* giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java
* giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java
* giraph-core/src/test/java/org/apache/giraph/comm/SaslConnectionTest.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java
* giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java
* giraph-core/src/test/java/org/apache/giraph/BspCase.java
* giraph-core/src/test/java/org/apache/giraph/partition/TestPartitionStores.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyServer.java
* giraph-core/src/main/java/org/apache/giraph/job/GiraphJob.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/SaslServerHandler.java
* giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java
*
giraph-core/src/main/java/org/apache/giraph/comm/netty/handler/ResponseClientHandler.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
* giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java
* giraph-core/src/main/java/org/apache/giraph/zk/GiraphZooKeeperAdmin.java
* giraph-core/src/main/java/org/apache/giraph/conf/IntConfOption.java
* giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java
* giraph-examples/src/test/java/org/apache/giraph/vertex/TestVertexTypes.java
*
giraph-core/src/main/java/org/apache/giraph/partition/DiskBackedPartitionStore.java
* giraph-core/src/main/java/org/apache/giraph/partition/PartitionUtils.java
* giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java
* giraph-core/src/test/java/org/apache/giraph/conf/TestGiraphConfiguration.java
* giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java
* giraph-core/src/main/java/org/apache/giraph/conf/FloatConfOption.java
* CHANGELOG
* checkstyle.xml
* giraph-core/src/main/java/org/apache/giraph/master/MasterThread.java
*
giraph-core/src/main/java/org/apache/giraph/comm/messages/SequentialFileMessageStore.java
* giraph-core/src/main/java/org/apache/giraph/conf/BooleanConfOption.java
* giraph-examples/src/test/java/org/apache/giraph/TestPartitionContext.java
* giraph-core/src/main/java/org/apache/giraph/comm/SendEdgeCache.java
* giraph-core/src/main/java/org/apache/giraph/conf/ConfOptionType.java
* giraph-core/src/main/java/org/apache/giraph/conf/LongConfOption.java
*
giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java
* giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java
* giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java
* giraph-core/src/main/java/org/apache/giraph/utils/JMapHistoDumper.java
*
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
* giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java
*
giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java
* giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java
* giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
* giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java
* giraph-core/src/test/java/org/apache/giraph/conf/TestObjectCreation.java
> Refactor configuration options
> ------------------------------
>
> Key: GIRAPH-587
> URL: https://issues.apache.org/jira/browse/GIRAPH-587
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
>
> Introduce smart helper clases to hold configuration options (IntConfOption,
> StrConfOption, ClassConfOption, etc).
> This has many nice effects:
> - Default value stored with the option key itself.
> - Much simpler, less casting, clearer code. In other words, diff has more red
> than green :).
> - Don't have to have two constants for every option (one for name, one for
> default value)
> - Can do things with the options now that they're actual objects. For example
> with little code I added an AllOptions class that prints out all of the
> giraph options. See https://gist.github.com/nitay/5258920
> Some other things we could do:
> - Add description into the object. Auto generate docs.
> - Ensure that options begin with "giraph."
> And so on.
> Note there's no logic change here.
> https://reviews.apache.org/r/10156/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
