> On March 30, 2013, 6:53 a.m., Eli Reisman wrote: > > Great idea. Hey have you considered using (or abusing) > > OutputCommitter#commitTask, which must be called per-task to save each > > tasks' results for the superstep? It is normally used at the end of a job > > but could be used per-superstep to just bulk dump all the vertices output > > data anytime you want in the processing loop. > >
I tried using that, but for some reason it didn't work for me, maybe I should try again. But I agree with the idea - we do want to have an option to dump these output files per superstep. - Maja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10201/#review18554 ----------------------------------------------------------- On March 30, 2013, 2:11 a.m., Maja Kabiljo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10201/ > ----------------------------------------------------------- > > (Updated March 30, 2013, 2:11 a.m.) > > > Review request for giraph. > > > Description > ------- > > https://issues.apache.org/jira/browse/GIRAPH-600 > > > This addresses bug GIRAPH-600. > https://issues.apache.org/jira/browse/GIRAPH-600 > > > Diffs > ----- > > > giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java > 56b5d03 > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java > 963b82a > giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java > c5b9b93 > > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java > 76f6105 > giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java > 4840471 > giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java > 57f7dff > giraph-core/src/main/java/org/apache/giraph/io/SimpleVertexWriter.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/io/VertexWriter.java 38c5548 > > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/MultiThreadedSuperstepOutput.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/NoOpSuperstepOutput.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/SuperstepOutput.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/SynchronizedSuperstepOutput.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/io/superstep_output/package-info.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java > 74c1f87 > > Diff: https://reviews.apache.org/r/10201/diff/ > > > Testing > ------- > > mvn clean install > Real application using SynchronizedSuperstepOutput > > > Thanks, > > Maja Kabiljo > >
