----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10248/#review18631 -----------------------------------------------------------
Ship it! +1 from me, great idea, needed to be done! Might want to run a job or two (that runs on GiraphRunner) before to commit to see if anything with the generic type validation code gets weird on us but this seems pretty straightforward. - Eli Reisman On April 3, 2013, 3:51 a.m., Maja Kabiljo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10248/ > ----------------------------------------------------------- > > (Updated April 3, 2013, 3:51 a.m.) > > > Review request for giraph. > > > Description > ------- > > Input formats / readers shouldn't require message type. No logic change. > > > This addresses bug GIRAPH-589. > https://issues.apache.org/jira/browse/GIRAPH-589 > > > Diffs > ----- > > > giraph-accumulo/src/main/java/org/apache/giraph/io/accumulo/AccumuloVertexInputFormat.java > 9445fd4 > > giraph-accumulo/src/test/java/org/apache/giraph/io/accumulo/edgemarker/AccumuloEdgeInputFormat.java > 4cbbc89 > giraph-core/src/main/java/org/apache/giraph/conf/GiraphClasses.java e03859a > > giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java > e290c57 > giraph-core/src/main/java/org/apache/giraph/io/BasicVertexValueReader.java > 1ccde39 > giraph-core/src/main/java/org/apache/giraph/io/VertexInputFormat.java > ded8b92 > giraph-core/src/main/java/org/apache/giraph/io/VertexReader.java 3487cee > giraph-core/src/main/java/org/apache/giraph/io/VertexValueInputFormat.java > 1ebda13 > giraph-core/src/main/java/org/apache/giraph/io/VertexValueReader.java > 3ccb0fd > > giraph-core/src/main/java/org/apache/giraph/io/formats/AdjacencyListTextVertexInputFormat.java > 8fe0db6 > > giraph-core/src/main/java/org/apache/giraph/io/formats/GeneratedVertexInputFormat.java > 1ae125f > > giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullIntTextInputFormat.java > 28539f5 > > giraph-core/src/main/java/org/apache/giraph/io/formats/IntIntNullTextInputFormat.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/io/formats/IntNullNullNullTextInputFormat.java > 4950d21 > > giraph-core/src/main/java/org/apache/giraph/io/formats/IntNullNullTextInputFormat.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/io/formats/JsonBase64VertexInputFormat.java > 6eaf7dc > > giraph-core/src/main/java/org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java > 2ac2dad > > giraph-core/src/main/java/org/apache/giraph/io/formats/LongDoubleDoubleAdjacencyListVertexInputFormat.java > 09fb991 > > giraph-core/src/main/java/org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java > 40a20e1 > > giraph-core/src/main/java/org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java > 1071196 > > giraph-core/src/main/java/org/apache/giraph/io/formats/TextDoubleDoubleAdjacencyListVertexInputFormat.java > f7da40f > > giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexInputFormat.java > 898e57f > > giraph-core/src/main/java/org/apache/giraph/io/formats/TextVertexValueInputFormat.java > e09f6a3 > > giraph-core/src/main/java/org/apache/giraph/io/iterables/VertexReaderWrapper.java > 7493942 > > giraph-core/src/main/java/org/apache/giraph/job/GiraphConfigurationValidator.java > f55cf18 > giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java > 404e47e > > giraph-core/src/main/java/org/apache/giraph/utils/InMemoryVertexInputFormat.java > 0ed9155 > > giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java > 570b1bc > > giraph-core/src/test/java/org/apache/giraph/io/TestLongDoubleDoubleAdjacencyListVertexInputFormat.java > 6a0b912 > > giraph-core/src/test/java/org/apache/giraph/io/TestTextDoubleDoubleAdjacencyListVertexInputFormat.java > 6d81f51 > giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java > 10bb4d0 > > giraph-examples/src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java > 26f970d > > giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleDoubleTextInputFormat.java > 6fef9f2 > > giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java > PRE-CREATION > > giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullDoubleTextInputFormat.java > e22194a > > giraph-examples/src/main/java/org/apache/giraph/examples/LongDoubleNullTextInputFormat.java > PRE-CREATION > > giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleDoubleTextInputFormat.java > 50d527c > > giraph-examples/src/main/java/org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java > PRE-CREATION > > giraph-examples/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java > 224b8f2 > > giraph-examples/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java > 8313a2b > giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java 666a50b > > giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java > 5cc25be > > giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java > 27cd267 > > giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java > 9672d20 > > giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java > 1ae9c52 > > giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java > c8ca8a1 > > giraph-hbase/src/main/java/org/apache/giraph/io/hbase/HBaseVertexInputFormat.java > bbcbc1b > > giraph-hbase/src/test/java/org/apache/giraph/io/hbase/edgemarker/TableEdgeInputFormat.java > 8e209af > > giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexInputFormat.java > fd5fb5c > > giraph-hcatalog/src/main/java/org/apache/giraph/io/hcatalog/HCatalogVertexValueInputFormat.java > f365578 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/AbstractHiveToEdge.java > c16e808 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/HiveEdgeReader.java > e1a69cf > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/SimpleHiveToEdge.java > 94a811e > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/AbstractHiveToVertex.java > a138846 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveToVertex.java > f57dc4e > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexInputFormat.java > 3b25444 > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/HiveVertexReader.java > 9c172be > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleHiveToVertex.java > 59c10be > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/SimpleNoEdgesHiveToVertex.java > ca427a0 > > Diff: https://reviews.apache.org/r/10248/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Maja Kabiljo > >
