----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10598/#review19399 -----------------------------------------------------------
Writing down some comments from our offline discussion. giraph-core/src/main/java/org/apache/giraph/edge/EdgeIterables.java <https://reviews.apache.org/r/10598/#comment40110> There is already an EdgeIterables class in utils, so they should probably be merged. giraph-core/src/main/java/org/apache/giraph/edge/EdgeIterables.java <https://reviews.apache.org/r/10598/#comment40111> I would rename to size() for consistency with other similar methods. giraph-core/src/main/java/org/apache/giraph/edge/EdgeIterables.java <https://reviews.apache.org/r/10598/#comment40112> As discussed offline, this is not required. giraph-core/src/main/java/org/apache/giraph/edge/EdgeIterables.java <https://reviews.apache.org/r/10598/#comment40113> As discussed offline, this should actually initialize the edges. We first try to get the size cheaply, and then call add(). All provided OutEdges implementations will call this helper method. - Alessandro Presta On April 18, 2013, 12:41 a.m., Maja Kabiljo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10598/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 12:41 a.m.) > > > Review request for giraph. > > > Description > ------- > > Compute OutEdges can for example be immutable, or have better performance > when adding all edges than when adding one by one. > > > This addresses bug giraph-636. > https://issues.apache.org/jira/browse/giraph-636 > > > Diffs > ----- > > giraph-core/src/main/java/org/apache/giraph/edge/EdgeIterables.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/edge/EdgeStore.java 81044bd > giraph-core/src/main/java/org/apache/giraph/edge/HashMapEdges.java fc23cf0 > giraph-core/src/main/java/org/apache/giraph/edge/HashMultimapEdges.java > abe6151 > giraph-core/src/main/java/org/apache/giraph/edge/IntNullArrayEdges.java > 9867771 > giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleArrayEdges.java > 45d182e > > giraph-core/src/main/java/org/apache/giraph/edge/LongDoubleHashMapEdges.java > c33200d > giraph-core/src/main/java/org/apache/giraph/edge/LongNullArrayEdges.java > d753588 > giraph-core/src/main/java/org/apache/giraph/edge/LongNullHashSetEdges.java > ef0302c > > Diff: https://reviews.apache.org/r/10598/diff/ > > > Testing > ------- > > mvn clean verify > Application run which requires this kind of initialization > > > Thanks, > > Maja Kabiljo > >
