Alessandro Presta created GIRAPH-668:
----------------------------------------
Summary: GiraphConfigurationValidator is broken
Key: GIRAPH-668
URL: https://issues.apache.org/jira/browse/GIRAPH-668
Project: Giraph
Issue Type: Bug
Reporter: Alessandro Presta
GiraphConfigurationValidator is supposed to compare the I, V, E, M parameters
across all user-specified classes, and signal mismatches.
Unfortunately, there are a few issues that make it more of a hassle than a help:
1) ReflectionUtils, which is used to extract type information, doesn't work
when the base is an interface instead of an abstract class (this is a problem
with VertexValueFactory and OutEdges, see for example
https://issues.apache.org/jira/browse/GIRAPH-644?focusedCommentId=13640687&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13640687)
2) In at least one case (VertexValueInputFormat), we specialize one argument to
Writable. This will always give a mismatch with the actual type specified in
the Vertex. In those cases, we should bypass checking that argument.
Ideally we should fix all these issues and also make sure
GiraphConfigurationValidator is called for any job (not only when using
GiraphRunner).
If this can't be easily done, we should at least (partially) disable the checks
so that we don't fail jobs that have nothing wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
