-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12083/
-----------------------------------------------------------

Review request for giraph.


Bugs: GIRAPH-697
    https://issues.apache.org/jira/browse/GIRAPH-697


Repository: giraph-git


Description
-------

No logic change, just some refactoring. There is just MessageStore interface 
now, which message stores have to implement, and it's simpler than the old 
MessageStoreByPartition - has only methods which are required by the 
infrastructure. Moved out-of-core to its own package, also layers there are not 
that general anymore, but we were assuming that we are using specific message 
stores on each layer anyways.


Diffs
-----

  giraph-core/src/main/java/org/apache/giraph/comm/ServerData.java 
788be5335723d0d092628c3f967c87c8d49fcb9e 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/BasicMessageStore.java
 dcb622364d4d1929b2dded7e6f33537e8bfeeb8d 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/ByteArrayMessagesPerVertexStore.java
 97c8a35cf50d9f7a5dc84d783036324f3ec18f7d 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/DiskBackedMessageStore.java
 2712eddadb6044995ce8cbaa41effa71181b88e4 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/DiskBackedMessageStoreByPartition.java
 4a2894933e667633199095a47ec3737f615382af 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/FlushableMessageStore.java
 6e7fe55cfe6f56b4711226b503725c3792080dd9 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/InMemoryMessageStoreFactory.java
 9086d78e668cb9d8e48881384de98be621f88ba3 
  giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStore.java 
a6f174d2752b4515bf7827a808a3f9d1d0ff88b6 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStoreByPartition.java
 d2143c66bdc415a158ee62e1cb622eaa0c556199 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/MessageStoreFactory.java
 dec9a92c345f138386e587069657c5c2eb371512 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/MessagesIterable.java 
PRE-CREATION 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
 8710dac2fc43343c9d67818261afaee0eb085c0f 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/SequentialFileMessageStore.java
 23bbbc50304321701c1de3480a6269db37197dec 
  
giraph-core/src/main/java/org/apache/giraph/comm/messages/SimpleMessageStore.java
 1a91dfb00cea7243b27c22e07cedeeef77436aa5 
  giraph-core/src/main/java/org/apache/giraph/comm/messages/package-info.java 
3c798a95d62ea09266ae4623741dd16755cba76a 
  
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
 2adf19d9234cf7f039ee7219e763a559f85642bc 
  giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyWorkerServer.java 
b45703853a6e5c57a5854cc40036912a20c59293 
  giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java 
6fdcfb05b102a78744d84bcba4e8dc8c30a3e25c 
  giraph-core/src/main/java/org/apache/giraph/graph/GraphTaskManager.java 
435dd879beb2ce4e3cfd4ed7c5f5922c7c4892b0 
  giraph-core/src/test/java/org/apache/giraph/comm/RequestFailureTest.java 
5c69161a9dd628a99bfcff2fb48a2619a36d4046 
  giraph-core/src/test/java/org/apache/giraph/comm/RequestTest.java 
70165729d5230a2620465ffbc69affc1896e1431 
  giraph-core/src/test/java/org/apache/giraph/comm/TestMessageStores.java 
4e8041a865e0f7173d004677d4c841a64ba4a5a2 

Diff: https://reviews.apache.org/r/12083/diff/


Testing
-------

mvn clean verify


Thanks,

Maja Kabiljo

Reply via email to