----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12253/#review22857 -----------------------------------------------------------
Still need to add an exception for null column name in columnIndexOrThrow(). Other than that, +1 - Alessandro Presta On July 7, 2013, 2:14 p.m., Nitay Joffe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12253/ > ----------------------------------------------------------- > > (Updated July 7, 2013, 2:14 p.m.) > > > Review request for giraph. > > > Bugs: GIRAPH-705 > https://issues.apache.org/jira/browse/GIRAPH-705 > > > Repository: giraph-git > > > Description > ------- > > Type converters and giraph-hive cleanup > > > Diffs > ----- > > > giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java > d88ff0d8376357035c6944fb2dbdcb9c4614d3d3 > giraph-core/src/main/java/org/apache/giraph/jython/JythonUtils.java > f456aa8b6a665925ceabe8983df07239dfc171ad > > giraph-core/src/main/java/org/apache/giraph/types/BooleanToBooleanWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/BooleanWritableToBooleanUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteToByteWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteToIntWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteToLongWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteWritableToByteUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteWritableToIntUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteWritableToLongUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ByteWritableToShortUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/DoubleToDoubleWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/DoubleWritableToDoubleUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/FloatToDoubleWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/FloatToFloatWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/FloatWritableToDoubleUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/FloatWritableToFloatUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/IntToIntWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/IntToLongWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/IntWritableToIntUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/IntWritableToLongUnwrapper.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/types/JavaWritablePair.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/LongToLongWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/LongWritableToLongUnwrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ShortToIntWritableWrapper.java > PRE-CREATION > > giraph-core/src/main/java/org/apache/giraph/types/ShortToLongWritableWrapper.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/types/WritableUnwrapper.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/types/WritableUnwrappers.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/types/WritableWrapper.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/types/WritableWrappers.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/types/package-info.java > PRE-CREATION > giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java > f0a7e4f784f970250f6f515a261b19f15e18fbc7 > > giraph-core/src/main/java/org/apache/giraph/utils/DistributedCacheUtils.java > 6abe89b068e17823a3083061cb213c53c5b72f0d > giraph-core/src/test/java/org/apache/giraph/jython/TestJython.java > 245d342ddf903c83130e299a33d0bee74cfc6949 > giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java > 589fed6c746c8f988f36cc439e78bc389b4b6e40 > giraph-hive/src/main/java/org/apache/giraph/hive/common/HiveUtils.java > 11b060f603b32ead84799a818d4604b0b1ba14af > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/SimpleHiveToEdge.java > 56b38f9d740aacdf72f1d710fbfa0c2de833936a > > giraph-hive/src/main/java/org/apache/giraph/hive/input/edge/TypedHiveToEdge.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/input/vertex/TypedHiveToVertex.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/output/AbstractVertexToHive.java > 477ce6e3da499d96e3dc50fd35edeae649c85192 > > giraph-hive/src/main/java/org/apache/giraph/hive/output/HiveVertexWriter.java > bb27f25c627f50c3b1bb48d027e42631f3b0855c > > giraph-hive/src/main/java/org/apache/giraph/hive/output/TypedVertexToHive.java > PRE-CREATION > giraph-hive/src/main/java/org/apache/giraph/hive/output/VertexToHive.java > f9537a779a47d7eff374dcf4db2557f3495f6969 > giraph-hive/src/main/java/org/apache/giraph/hive/types/HiveValueReader.java > PRE-CREATION > giraph-hive/src/main/java/org/apache/giraph/hive/types/HiveValueWriter.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/types/HiveVertexIdReader.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/types/HiveVertexIdWriter.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/types/TypedValueReader.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/types/TypedValueWriter.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/types/TypedVertexIdReader.java > PRE-CREATION > > giraph-hive/src/main/java/org/apache/giraph/hive/types/TypedVertexIdWriter.java > PRE-CREATION > giraph-hive/src/main/java/org/apache/giraph/hive/types/package-info.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12253/diff/ > > > Testing > ------- > > > Thanks, > > Nitay Joffe > >
