> On July 23, 2013, 2:17 p.m., Armando wrote: > > Looks very good time. Some comments: > > > > 1) Gremlin is actually spelt with an E and not Gramlin > > 2) I think the default hostname should be "", as the default 127.0.0.1 can > > be misleading > > 3) You can probably live without the gremlin enable property and just infer > > it by the existence of one of the two other parameters (for edges or > > vertices) > > 4) Could be an improvement to use a commons lib to actually build the HTTP > > url instead of manual String. I'm sure it works, but it could help. > > Claudio Martella wrote: > :) this is actually my review.
I modified everything you asked but I am not sure what you meant with the URL thingy. What I did is ok or were you thinking about something specific? - Armando ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12813/#review23637 ----------------------------------------------------------- On July 22, 2013, 1:55 p.m., Armando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12813/ > ----------------------------------------------------------- > > (Updated July 22, 2013, 1:55 p.m.) > > > Review request for giraph. > > > Repository: giraph-git > > > Description > ------- > > This patch provides support for Rexster in Giraph via an Input Format. The > main classes are RexsterVertexInputFormat and RexsterEdgeInputFormat which > can be extended by the user to implement customary InputFormats for Rexster. > The patch also includes: > (a) support for gremlin scripts > (b) tests on the example user classes > (c) a page documentation about the InputFormat and how this can be used. > > > Diffs > ----- > > giraph-rexster/pom.xml PRE-CREATION > giraph-rexster/src/main/assembly/compile.xml PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/conf/GiraphRexsterConstants.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/conf/package-info.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterEdgeInputFormat.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterInputSplit.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/RexsterVertexInputFormat.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongDoubleFloatVertexInputFormat.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/RexsterLongFloatEdgeInputFormat.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/formats/package-info.java > PRE-CREATION > giraph-rexster/src/main/java/org/apache/giraph/rexster/io/package-info.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/RexsterUtils.java > PRE-CREATION > > giraph-rexster/src/main/java/org/apache/giraph/rexster/utils/package-info.java > PRE-CREATION > > giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestAbstractRexsterInputFormat.java > PRE-CREATION > > giraph-rexster/src/test/java/org/apache/giraph/rexster/io/formats/TestRexsterLongDoubleFloatVertexInputFormat.java > PRE-CREATION > > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/empty-db.input.json > PRE-CREATION > > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/rexster.xml > PRE-CREATION > > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/test-db.input.json > PRE-CREATION > > giraph-rexster/src/test/resources/org/apache/giraph/rexster/io/formats/test-db.output.json > PRE-CREATION > pom.xml 1131a56 > src/site/site.xml 561fbc0 > src/site/xdoc/rexster.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/12813/diff/ > > > Testing > ------- > > I tested: > (a) empty database > (b) a toy database without query > (c) a toy database using a gremlin query > > I tested both with TinkerGraph and with Neo4jGraph > > > Thanks, > > Armando > >
