[ 
https://issues.apache.org/jira/browse/GIRAPH-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724255#comment-13724255
 ] 

Maja Kabiljo commented on GIRAPH-725:
-------------------------------------

Good catch, thanks for fixing it, +1. Just make sure it passes 'mvn clean 
verify', I think missing param tag causes checkstyle error. 
                
> AggregatorWrapper instantiates aggregator bypassing ReflectionUtils
> -------------------------------------------------------------------
>
>                 Key: GIRAPH-725
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-725
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-725.patch
>
>
> AggregatorWrapper creates the current aggregator by directly calling 
> newInstance() on its class. If the user defined a configurable aggregator, 
> setConf() won't be called here as one would expect, which leads to bugs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to