Kyle Orlando created GIRAPH-739:
-----------------------------------

             Summary: Discrepancy among numeric constants corresponding to 
frequency of writing in TextAggregatorWriter
                 Key: GIRAPH-739
                 URL: https://issues.apache.org/jira/browse/GIRAPH-739
             Project: Giraph
          Issue Type: Bug
            Reporter: Kyle Orlando
            Priority: Minor


In the TextAggreggatorWriter class in org.apache.giraph.aggregators, there are 
static constants at the top of the class that correspond to the frequency of 
writing.  

The _NEVER_ constant corresponds to never writing anything to a file, and it is 
assigned an (int) value of 0. 

_AT_THE_END_ corresponds to writing to a file only once, when the computation 
is over, and it is assigned a numeric value of -1. 
 
The third type of frequency is where the discrepancy exists: _ALWAYS_ 
corresponds to writing to a file in every superstep, and it is also assigned a 
numeric value of -1.  

_ALWAYS_'s value should be changed to a 1. This is because the condition for 
writing (as governed by the shouldWrite() method) can be met when superstep % 
frequency == 0, which is always the case when frequency == 1. 
 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to